From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753650AbbGNIe6 (ORCPT ); Tue, 14 Jul 2015 04:34:58 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:33451 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753619AbbGNIez (ORCPT ); Tue, 14 Jul 2015 04:34:55 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Tue, 14 Jul 2015 09:34:54 +0100 Message-ID: <55A4C9AB.4080501@imgtec.com> Date: Tue, 14 Jul 2015 09:34:51 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thomas Gleixner , LKML CC: Jiang Liu Subject: Re: [patch 1/1] metag/irq: Use access helper irq_data_get_affinity_mask() References: <20150713131227.130911141@linutronix.de> In-Reply-To: <20150713131227.130911141@linutronix.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PuUgX05puiMjj3s6L2mgmTb9kgmsqgJaB" X-Originating-IP: [192.168.154.110] X-ESG-ENCRYPT-TAG: f107b6f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PuUgX05puiMjj3s6L2mgmTb9kgmsqgJaB Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Hi, On 13/07/15 21:43, Thomas Gleixner wrote: > From: Jiang Liu >=20 > This is a preparatory patch for moving irq_data struct members. >=20 > Signed-off-by: Jiang Liu > Cc: James Hogan > Signed-off-by: Thomas Gleixner Looks reasonable. Do you want this to go through metag tree? If not, Acked-by: James Hogan Cheers James > --- > arch/metag/kernel/irq.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > Index: tip/arch/metag/kernel/irq.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- tip.orig/arch/metag/kernel/irq.c > +++ tip/arch/metag/kernel/irq.c > @@ -270,23 +270,25 @@ void migrate_irqs(void) > =20 > for_each_active_irq(i) { > struct irq_data *data =3D irq_get_irq_data(i); > + struct cpumask *mask; > unsigned int newcpu; > =20 > if (irqd_is_per_cpu(data)) > continue; > =20 > - if (!cpumask_test_cpu(cpu, data->affinity)) > + mask =3D irq_data_get_affinity_mask(data); > + if (!cpumask_test_cpu(cpu, mask)) > continue; > =20 > - newcpu =3D cpumask_any_and(data->affinity, cpu_online_mask); > + newcpu =3D cpumask_any_and(mask, cpu_online_mask); > =20 > if (newcpu >=3D nr_cpu_ids) { > pr_info_ratelimited("IRQ%u no longer affine to CPU%u\n", > i, cpu); > =20 > - cpumask_setall(data->affinity); > + cpumask_setall(mask); > } > - irq_set_affinity(i, data->affinity); > + irq_set_affinity(i, mask); > } > } > #endif /* CONFIG_HOTPLUG_CPU */ >=20 >=20 --PuUgX05puiMjj3s6L2mgmTb9kgmsqgJaB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVpMmzAAoJEGwLaZPeOHZ6l98QAKNgUyIosXV/g/RTTx80nwmp JAon0bmfHQoTyslu4XhqXV3RVUg7w0tceJK10s7Dk06CwMx3w5vGmcpuirHOzXCc NBkBSM5rXfZfuuGl9SW620isT2Ik2az1tJW0wyBn1FczNSs9ljERBFZuP/MpDAAU XSGJg/if+ow/Z8pRK0lC6moGMwHVihU+HyJhvcprPiSOcH3XYCQ+Gm2SDyszX4z/ 9cmsuGQHdWa7lrSH0ORMwjw6JvAxrfEwuEfalXA6kYIrpkxI3hnh+TrtET35jP8N BnAYGTb5DY/LDifxsxhvJn/Isb2+i3Eq7RlQjpsvSb5SoAMEe9OUAN32mvNJgXep Ego6a8STZbnYCOL04IcaBO8CV3dhfmqnPLslfqQ6sCkhZldnYQWhS6ZZ5UB4boxL xq1TdE5Y3vmc6iUJqTkGpTtsAGa7ILOjlRGuuvrGwCI2G78qwm4s4W3+RFwixK0Z mb1fHl8rikhYvKLLyRy1TA9mZDgQ9eAjZFHUN2diJJZSLrXhPdmTgyUN52MmVg3J Vs0Tt+OkW9ScakIkcbgUFLh1UXV/BvdTVucdpSm4aqv9ebOXXwzFEMWozyyC+gQB 9A4C2tPQFiHKkzBJXfAQ9JZeOa7KJIdycPYYjBK1M1P+ciB6ItI8LM2fiAAvsy77 q/t1YDf4+cOJZ2k1/CAM =DGG4 -----END PGP SIGNATURE----- --PuUgX05puiMjj3s6L2mgmTb9kgmsqgJaB--