From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757079AbbGQHQp (ORCPT ); Fri, 17 Jul 2015 03:16:45 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:59408 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbbGQHQn (ORCPT ); Fri, 17 Jul 2015 03:16:43 -0400 X-AuditID: cbfee691-f79ca6d00000456a-e4-55a8abd96b64 Message-id: <55A8ABD8.7000705@samsung.com> Date: Fri, 17 Jul 2015 16:16:40 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: myungjoo.ham@samsung.com Cc: "edubezval@gmail.com" , "rui.zhang@intel.com" , =?UTF-8?B?67CV6rK966+8?= , "ulf.hansson@linaro.org" , "khilman@linaro.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , =?UTF-8?B?64yA7J246riw?= , Lukasz Majewski , =?UTF-8?B?6rmA6rWt7KeE?= , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device References: <921188645.36001437115238708.JavaMail.weblogic@epmlwas08c> In-reply-to: <921188645.36001437115238708.JavaMail.weblogic@epmlwas08c> Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsWyRsSkQPfm6hWhBheXKlnMP3KO1WL+lWus FuderWS0mHR/AotF74KrbBZfD69gtDjb9Ibd4s3DzYwWl3fNYbP43HuE0WLp9YtMFrcbV7BZ TJi+lsWide8RdosnD/vYLI6vDXcQ8Fgzbw2jx85Zd9k9Vi7/wuaxeM9LJo9NqzrZPO5c28Pm 0bdlFaPH501yARxRXDYpqTmZZalF+nYJXBkTjr1jKzjAWfHy7k2WBsYz7F2MnBwSAiYSx6c9 YoOwxSQu3FsPZHNxCAksZZTY09DFBFO0Y99LdojEIkaJtXf7WCGcB4wSmydsAxvFK6Alse7+ BUYQm0VAVWLVkR2sIDYbUHz/ixtgK0QFwiRWTr/CAlEvKPFj8j0wW0RARuLqxu0sIEOZBSaw SRzYdw4sISzgIbHi6UWwM4QE3CRW3n0EtICDg1PAXeLCOm2QMLOAusSkeYuYIWx5ic1r3jKD zJEQWMohsWXJenaIgwQkvk0+xALSKyEgK7HpADPEZ5ISB1fcYJnAKDYLyUmzkIydhWTsAkbm VYyiqQXJBcVJ6UWmesWJucWleel6yfm5mxiB8X7637OJOxjvH7A+xCjAwajEw9vguiJUiDWx rLgy9xCjKdAVE5mlRJPzgUklryTe0NjMyMLUxNTYyNzSTEmcV0f6Z7CQQHpiSWp2ampBalF8 UWlOavEhRiYOTqkGRv8w7a/TtN8pH1rA//HWfMcdG7UkGHWk98y5cLyeK+pY7ESmPY4eKZan fk4veDB39YTbiTujZvsyvjwRtY3j4fr9+nt9eWclRulLn9/fvSDVyvh44M+ZmfxFu1td5mSE bOyyee0XNFepacFFy5jrh2YsuiP02EH4tuYO47BN//IX7XJ/pPsoZZ8SS3FGoqEWc1FxIgDj 10qv8gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsVy+t9jAd2bq1eEGnydKm0x/8g5Vov5V66x Wpx7tZLRYtL9CSwWvQuusll8PbyC0eJs0xt2izcPNzNaXN41h83ic+8RRoul1y8yWdxuXMFm MWH6WhaL1r1H2C2ePOxjszi+NtxBwGPNvDWMHjtn3WX3WLn8C5vH4j0vmTw2repk87hzbQ+b R9+WVYwenzfJBXBENTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoq ufgE6Lpl5gC9oKRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHMmHDsHVvB Ac6Kl3dvsjQwnmHvYuTkkBAwkdix7yWULSZx4d56ti5GLg4hgUWMEmvv9rFCOA8YJTZP2AZW xSugJbHu/gVGEJtFQFVi1ZEdrCA2G1B8/4sbbCC2qECYxMrpV1gg6gUlfky+B2aLCMhIXN24 nQVkKLPABDaJA/vOgSWEBTwkVjy9yARiCwm4Say8+whoAQcHp4C7xIV12iBhZgF1iUnzFjFD 2PISm9e8ZZ7AKDALyYpZSMpmISlbwMi8ilE0tSC5oDgpPddQrzgxt7g0L10vOT93EyM4mTyT 2sG4ssHiEKMAB6MSD2+D64pQIdbEsuLK3EOMEhzMSiK8z6uBQrwpiZVVqUX58UWlOanFhxhN gSEwkVlKNDkfmOjySuINjU3MjCyNzA0tjIzNlcR5T+b7hAoJpCeWpGanphakFsH0MXFwSjUw 6u14V6w9eaWi9Ic/xkHnZwW4aZ3zPVIqJK7RblHLeNDxbvX58nXsxqFBfbKLyxeUOO1e+Z+B v3Si9sr5E5SU5Bfz39HdfqQr+Z+YhXiT/UH7TT2uoUK2V1oDfkrd3FqoGB+zxeIS+801P8R1 lz5gkcwquPZiiR+PeOG/19+na5zRUlKeukBNiaU4I9FQi7moOBEAmFR/czwDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Myungjoo, On 07/17/2015 03:40 PM, MyungJoo Ham wrote: >> >> This patchset introduce the generic devfreq cooling device for generic thermal >> framework. The devfreq devices are used ad cooling device to reduce the >> overheating temperature. This patch is based on drivers/thermal/cpu_cooling.c. >> The devfreq cooling device can change the ragne of the frequency table of >> devfreq device according to cooling level in device tree file. > > Hi, > > > 1. You've exported "update_devfreq()" in 1/2 and didn't use it anywhere. > 2. If you've added "update_devfreq()" to notify devfreq driver when a new > max/min is defined, you'll need to add it at set_state, OR > You may do it with opp_enable()/opp_disable() function and let opp > notifiers do the homework for you. (no need to update_devfreq(). It is my mistake. The devfreq_set_cur_state() in patch2 use the update_devfreq() to change the maximum frequency of devfreq device as following: + /* Set the limited frequency to maximum frequency of devfreq */ + devfreq_dev->devfreq->max_freq = limited_freq; + update_devfreq(devfreq_dev->devfreq); I'll resent v2 patch-set. Thanks, Chanwoo Choi