From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756496AbbGTIyf (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jul 2015 04:54:35 -0400
Received: from eusmtp01.atmel.com ([212.144.249.242]:34645 "EHLO
	eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756184AbbGTIyb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jul 2015 04:54:31 -0400
Message-ID: <55ACB72D.60506@atmel.com>
Date: Mon, 20 Jul 2015 10:54:05 +0200
From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        <nicolas.ferre@atmel.com>, <broonie@kernel.org>,
        <linux-spi@vger.kernel.org>, <dwmw2@infradead.org>,
        <computersforpeace@gmail.com>, <zajec5@gmail.com>,
        <beanhuo@micron.com>, <juhosg@openwrt.org>, <marex@denx.de>,
        <shijie.huang@intel.com>, <ben@decadent.org.uk>
CC: <mark.rutland@arm.com>, <devicetree@vger.kernel.org>, <pawel.moll@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <linux-kernel@vger.kernel.org>,
        <robh+dt@kernel.org>, <linux-mtd@lists.infradead.org>,
        <galak@codeaurora.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/7] Documentation: atmel-quadspi: add binding file for
 Atmel QSPI driver
References: <cover.1437059658.git.cyrille.pitchen@atmel.com> <f4bb1c68fcc19b3642110ab0ef9850d6eeca3112.1437059658.git.cyrille.pitchen@atmel.com> <55A8EAAE.6010506@cogentembedded.com>
In-Reply-To: <55A8EAAE.6010506@cogentembedded.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.161.30.18]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sergei,

thanks for the review. For the next series I've removed all references to
"qspi" in the node example but the one from the compatible string.
I've also removed the leading 0 in the size of the second memory region.

Best Regards,

Cyrille

Le 17/07/2015 13:44, Sergei Shtylyov a écrit :
> Hello.
> 
> On 7/16/2015 6:27 PM, Cyrille Pitchen wrote:
> 
>> This patch documents the DT bindings for the driver of the Atmel QSPI
>> controller embedded inside sama5d2x SoCs.
> 
>> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
>> ---
>>   .../devicetree/bindings/mtd/atmel-quadspi.txt      | 29 ++++++++++++++++++++++
>>   1 file changed, 29 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/mtd/atmel-quadspi.txt
> 
>> diff --git a/Documentation/devicetree/bindings/mtd/atmel-quadspi.txt b/Documentation/devicetree/bindings/mtd/atmel-quadspi.txt
>> new file mode 100644
>> index 000000000000..a0d60ac7ae10
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mtd/atmel-quadspi.txt
>> @@ -0,0 +1,29 @@
>> +* Atmel Quad Serial Peripheral Interface (QSPI)
>> +
>> +Required properties:
>> +  - compatible : Should be "atmel,sama5d2-qspi"
>> +  - reg : the first contains the register location and length,
>> +          the second contains the memory mapping address and length
>> +  - interrupts : Should contain the interrupt for the device
>> +  - clocks : The clock needed by the QSPI controller
>> +  - #address-cells : should be 1
>> +  - #size-cells : should be 0
>> +
>> +Example:
>> +
>> +qspi0: qspi@f0020000 {
> 
>     Once again, the ePAPR standard tells up to call the node just "spi", not "qspi".
> 
>> +    compatible = "atmel,sama5d2-qspi";
>> +    reg = <0xf0020000 0x100>,
>> +          <0xd0000000 0x08000000>;
> 
>    Either you use the leading zeroes or you don't. :-)
> 
> [...]
> 
> MBR, Sergei
>