From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933046AbbGTPIU (ORCPT ); Mon, 20 Jul 2015 11:08:20 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:42852 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753113AbbGTPIS (ORCPT ); Mon, 20 Jul 2015 11:08:18 -0400 X-AuditID: cbfec7f5-f794b6d000001495-d9-55ad0edee52e Message-id: <55AD0EDD.70201@samsung.com> Date: Mon, 20 Jul 2015 17:08:13 +0200 From: Krzysztof Opasiak User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-version: 1.0 To: Robert Baldyga , gregkh@linuxfoundation.org, balbi@ti.com Cc: Peter.Chen@freescale.com, johnyoun@synopsys.com, dahlmann.thomas@arcor.de, nicolas.ferre@atmel.com, cernekee@gmail.com, leoli@freescale.com, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, michal.simek@xilinx.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-geode@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, andrzej.p@samsung.com, m.szyprowski@samsung.com Subject: Re: [PATCH v3 26/46] usb: gadget: pch_ud: add ep capabilities support References: <1436941953-1327-1-git-send-email-r.baldyga@samsung.com> <1436941953-1327-27-git-send-email-r.baldyga@samsung.com> In-reply-to: <1436941953-1327-27-git-send-email-r.baldyga@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02RbUhTYRiGeXfebWdj09P86M3EYBWElGYIvkWJEcSBIPqRYinU1NMmbX7s QzJDRybiWK4aQc6smZqgc9ZcqFOTttIfyhJFycZU0BJTExtpTVw1R+C/63nui/v58ZCEaBzG kPkFakZZIJGLOXw4EhieODYb1pF+vOY+wKalaojfzVbgAbMX4JpZF4Hvbn+DuH/Uz8WVTZ0c PGZNwX0j4wD750TYNj/Fxgb3CMQTjqccXN9sgPjFyyoCb20G2LjjvZeLvy9l4o2JSi4eqt9m 4TlXLxebViLSomnjwmsWbfa/gfTMWxekDVYfmw64DCy61+Tl0oMNFi7d1VxBf3zSCOhaexug 7YM+QA9/6mbRPlscPeDbgnR3Xyu8FH6VfzqPkeeXMMrE1Ot82ag+q8gnuDVXN8nSgnq+DpAk opLR6sYNHeD9w2g0NtPJ0QE+KaJaANI/2uSGhkWA7JNNIGgJqSOo1ji9w5A6jBYCBhAs4lCJ 6JkjKriOojLR86FlIqTvQb+MMzDIkVQG0rUEmU8SVCVE3YtGTjCIoC4i8xcvK3RMC9Dgsnsn 4FHnkVln32kiqDPIvGaFIT6AuiyrxANAmXYdMe3STLs0MyDaQBSjyS1S5UgVJxJUEoVKUyBN yC1U2EDo0z97QMvQKSegSCAWCHv87ekitqREVapwAkQS4khh7LolXSTMk5TeZpSF15QaOaNy gv0kFO8V1jnWLosoqUTN3GSYIkb5P2WRvBgt0GTmJJdfKDt7L9eZ4mbJPCeT1ka31jPEf1Ld VzTjcfMui623Tv6j9eFwQKeOm1/86sx3yBY+JxRX8Yz6RgmnvN0Tr40V3vFnfZBOPi4Ly0nL nrbsK7H/rtEJ9IcaveegNVvs6T8YnaqS25Xh4cUr6leC6hV52NiU5+DRhjYxVMkkSfGEUiX5 C6KU2vLlAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2015 08:32 AM, Robert Baldyga wrote: > Convert endpoint configuration to new capabilities model. > > Signed-off-by: Robert Baldyga > --- > drivers/usb/gadget/udc/pch_udc.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c > index 613547f..cc8fb3c 100644 > --- a/drivers/usb/gadget/udc/pch_udc.c > +++ b/drivers/usb/gadget/udc/pch_udc.c > @@ -2895,11 +2895,21 @@ static void pch_udc_pcd_reinit(struct pch_udc_dev *dev) > ep->in = ~i & 1; > ep->ep.name = ep_string[i]; > ep->ep.ops = &pch_udc_ep_ops; > - if (ep->in) > + if (ep->in) { > ep->offset_addr = ep->num * UDC_EP_REG_SHIFT; > - else > + ep->ep.caps.dir_in = true; > + } else { > ep->offset_addr = (UDC_EPINT_OUT_SHIFT + ep->num) * > UDC_EP_REG_SHIFT; > + ep->ep.caps.dir_out = true; > + } > + if (i == UDC_EP0IN_IDX || i == UDC_EP0OUT_IDX) { > + ep->ep.caps.type_control = true; In all previous patches you set both dir_in and dir_out to true for ep0 but in this patch you don't do this. Is there some reason for this or it's just a mistake? > + } else { > + ep->ep.caps.type_iso = true; > + ep->ep.caps.type_bulk = true; > + ep->ep.caps.type_int = true; > + } > /* need to set ep->ep.maxpacket and set Default Configuration?*/ > usb_ep_set_maxpacket_limit(&ep->ep, UDC_BULK_MAX_PKT_SIZE); > list_add_tail(&ep->ep.ep_list, &dev->gadget.ep_list); > Best Regards, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics