From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507AbbGWP1d (ORCPT ); Thu, 23 Jul 2015 11:27:33 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:55540 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753574AbbGWP1Z (ORCPT ); Thu, 23 Jul 2015 11:27:25 -0400 Subject: Re: [PATCH v8 1/9] nvmem: Add a simple NVMEM framework for nvmem providers To: Srinivas Kandagatla , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman References: <1437403352-4091-1-git-send-email-srinivas.kandagatla@linaro.org> <1437403392-4136-1-git-send-email-srinivas.kandagatla@linaro.org> Cc: Rob Herring , Mark Brown , s.hauer@pengutronix.de, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, sboyd@codeaurora.org, pantelis.antoniou@konsulko.com, mporter@konsulko.com, wxt@rock-chips.com, Maxime Ripard From: Stefan Wahren Message-ID: <55B107B0.5010706@i2se.com> Date: Thu, 23 Jul 2015 17:26:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1437403392-4136-1-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:1oeXkzH7S0xbjDxomNxt9ep09lBdWqeESZBb1wcEfela66NHh/g l2hzXfGHY/VwchqnhexQIfoNwKlf7z06rYcSuIG5fccfvW73nlWFC9SSYHbzDhLnGtRZwVM qXjw21yZz67SQJ/zbppb1xD3XkX7CnOr0ypb8CkLzyisSxZPy/y3948RHJRWiq8E1nol2Ga KgA6A5F3UPLBsLjAVW32Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:ngY13L7mxfI=:vCduPZSP9iycUx9UJ1zNDm K4Lohucm6zFSywbdimdSjFiohbrROEI14ktl8rfXQMZBA2x3GUcbXdbW7QBgdrriuutvf1wVJ w7IcsMbZrJt2Bztq5GVMOI5EaoziFGAN7FiNOqyYKSgC/DlhsmZNtOKnUsc2qIiDpLWmh2DaH H4T+XhFCEvOnTQuHQfg2Z0FoK0nZ+O44xBqBgunigt5EZNLbY+V3qY7TBpFX3paandqOL2FhS T5/AAk0Y2bP6olDVS5XGJHZTQNqmYPksgKzsLWwOYhsDMuj3JIlBVJZBHD4dT52QCjy30CqrS 8NzhEwDhr7V0EtH8SJKNK4ra+ZPukXpZAsEs3G1q4wppobGJHKQ8dXppDEvNUKVdGXoqWdmil u2cIXhZl4Tsy9GOOVwxHw864H8QbAdeB5i7npVufT7io9ybrQEUB3KcmdM0TuZDjOWEdh1eQf TBeUuztHa0yjWXKHEtvH5TOFvtFhK6EuJNBKA5FR641adZIVtcuhVTjb/t5zGRTpqvNUtj9Lb ZOdfdg8NX+1n+RHyWmiuQovtfC2dYMeEGtTguziT6VtIMsXh/4DZsG3tYFYrRzh0X1MXxYUgW wx9HPcE0ElVab0gj3VJFjR2ZxPA7b1OV202nLDtmIxSHQnWJ5e0Lhiqlu5HY4NrOUx3Ic9XW6 Y2E/zjQUduhMJOetfVR9PfMfFq3QRxH2keQBfm06KIbGyag== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srinivas, Am 20.07.2015 um 16:43 schrieb Srinivas Kandagatla: > This patch adds just providers part of the framework just to enable easy > review. > > Up until now, NVMEM drivers like eeprom were stored in drivers/misc, > where they all had to duplicate pretty much the same code to register > a sysfs file, allow in-kernel users to access the content of the devices > they were driving, etc. > > This was also a problem as far as other in-kernel users were involved, > since the solutions used were pretty much different from on driver to > another, there was a rather big abstraction leak. > > This introduction of this framework aims at solving this. It also > introduces DT representation for consumer devices to go get the data > they require (MAC Addresses, SoC/Revision ID, part numbers, and so on) > from the nvmems. > > Having regmap interface to this framework would give much better > abstraction for nvmems on different buses. > > Signed-off-by: Maxime Ripard > [Maxime Ripard: intial version of eeprom framework] > Signed-off-by: Srinivas Kandagatla > --- > drivers/Kconfig | 2 + > drivers/Makefile | 1 + > drivers/nvmem/Kconfig | 13 ++ > drivers/nvmem/Makefile | 6 + > drivers/nvmem/core.c | 384 +++++++++++++++++++++++++++++++++++++++++ > include/linux/nvmem-consumer.h | 23 +++ > include/linux/nvmem-provider.h | 47 +++++ > 7 files changed, 476 insertions(+) > create mode 100644 drivers/nvmem/Kconfig > create mode 100644 drivers/nvmem/Makefile > create mode 100644 drivers/nvmem/core.c > create mode 100644 include/linux/nvmem-consumer.h > create mode 100644 include/linux/nvmem-provider.h i've tested this patch with my mxs-ocotp driver [1]. So you can add Tested-by: Stefan Wahren Regards Stefan