From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752566AbbG0G4w (ORCPT ); Mon, 27 Jul 2015 02:56:52 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:33502 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbbG0G4u (ORCPT ); Mon, 27 Jul 2015 02:56:50 -0400 Reply-To: monstr@monstr.eu Subject: Re: [RFCv2 2/3] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller. References: <1437783682-13632-1-git-send-email-moritz.fischer@ettus.com> <1437783682-13632-3-git-send-email-moritz.fischer@ettus.com> To: Moritz Fischer , p.zabel@pengutronix.de Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, galak@codeaurora.org, soren.brinkmann@xilinx.com, Nicolas Ferre From: Michal Simek Message-ID: <55B5D62D.4010407@monstr.eu> Date: Mon, 27 Jul 2015 08:56:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1437783682-13632-3-git-send-email-moritz.fischer@ettus.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TfxtXMauaU6PxsA8Im7Dpgr4aDmhPiDOV" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TfxtXMauaU6PxsA8Im7Dpgr4aDmhPiDOV Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Moritz, On 07/25/2015 02:21 AM, Moritz Fischer wrote: > Signed-off-by: Moritz Fischer > --- > arch/arm/boot/dts/zynq-7000.dtsi | 43 ++++++++++++- This patch is nice in general but every change in binding should be discussed separately. There is also necessary to wire them up in the driver to do action. That's why I think that will be the best just to add the code to slcr and keep others untouched. For example MACB/GEM is one example. Adding names to this node and extending driver to work properly with reset means that all others MACB users will be affected. Definitely this patch should be ACKed by Nicolas.= Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --TfxtXMauaU6PxsA8Im7Dpgr4aDmhPiDOV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iEYEARECAAYFAlW11i0ACgkQykllyylKDCGcfgCdEMHME5zyRjXGrdtVST8BzWea l80AoI1EABGrdKAXq9E/4FLAWVy2GaAf =LASs -----END PGP SIGNATURE----- --TfxtXMauaU6PxsA8Im7Dpgr4aDmhPiDOV--