From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754656AbbG1Fld (ORCPT ); Tue, 28 Jul 2015 01:41:33 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:36129 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472AbbG1Flb (ORCPT ); Tue, 28 Jul 2015 01:41:31 -0400 Reply-To: monstr@monstr.eu Subject: Re: [RFCv2 1/3] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings. References: <1437783682-13632-1-git-send-email-moritz.fischer@ettus.com> <1437783682-13632-2-git-send-email-moritz.fischer@ettus.com> <55B5BD08.60802@monstr.eu> To: Moritz Fischer Cc: p.zabel@pengutronix.de, mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, Michal Simek , linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel , Kumar Gala , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= From: Michal Simek Message-ID: <55B71607.1020303@monstr.eu> Date: Tue, 28 Jul 2015 07:41:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="v2S86wlILj3rCNuJwmdLVlGDjCqciAaCr" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --v2S86wlILj3rCNuJwmdLVlGDjCqciAaCr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/28/2015 06:55 AM, Moritz Fischer wrote: > Hi Michal, >=20 > On Sun, Jul 26, 2015 at 10:09 PM, Michal Simek wrote= : >> On 07/25/2015 02:21 AM, Moritz Fischer wrote: >>> Signed-off-by: Moritz Fischer >>> --- >>> Documentation/devicetree/bindings/reset/zynq-reset-pl.txt | 13 +++++= ++++++++ >>> 1 file changed, 13 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/reset/zynq-rese= t-pl.txt >>> >>> diff --git a/Documentation/devicetree/bindings/reset/zynq-reset-pl.tx= t b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt >>> new file mode 100644 >>> index 0000000..ac4499e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt >>> @@ -0,0 +1,13 @@ >>> +Xilinx Zynq PL Reset Manager >> >> here >> >>> + >>> +Required properties: >>> +- compatible: "xlnx,zynq-reset-pl" >> >> Currently it is not just PL reset controller. >> >>> +- syscon <&slcr>; >> >> >> missing : and please be more descriptive here. >> >>> +- #reset-cells: 1 >>> + >>> +Example: >>> + rstc: rstc@240 { >>> + #reset-cells =3D <1>; >>> + compatible =3D "xlnx,zynq-reset-pl"; >> >> Compatible property should go first. >> >> I am missing that reg property >> >>> + syscon =3D <&slcr>; >>> + }; >>> >> > Would something like this work: >=20 > Xilinx Zynq Reset Manager >=20 > The Zynq AP-SoC has several different resets. >=20 > See Chapter 26 of the Zynq TRM (UG585) for more information about Zynq = resets. >=20 > Required properties: > - compatible: "xlnx,zynq-reset" > - reg: SLCR offset and size taken via syscon <0x200 0x50> > - syscon: <&slcr> > This should be a phandle to the Zynq's SLCR register. > - #reset-cells: Must be 1 >=20 > The Zynq Reset Manager needs to be a child node of the SLCR. >=20 > Example: > rstc: rstc@200 { > compatible =3D "xlnx,zynq-reset"; > reg =3D <0x200 0x50>; > #reset-cells =3D <1>; > syscon =3D <&slcr>; > }; Looks good to me. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --v2S86wlILj3rCNuJwmdLVlGDjCqciAaCr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iEYEARECAAYFAlW3FgcACgkQykllyylKDCHGrwCeOzpC2AksslFiHGyH+jDKoqCy UDQAn0feAaIGAnh84FSxrYet6d+521Dh =7Idq -----END PGP SIGNATURE----- --v2S86wlILj3rCNuJwmdLVlGDjCqciAaCr--