From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932445AbbG1OuF (ORCPT ); Tue, 28 Jul 2015 10:50:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46678 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753575AbbG1OuB (ORCPT ); Tue, 28 Jul 2015 10:50:01 -0400 Subject: Re: [PATCH 0/2] New NAND chip IDs To: Michal Suchanek , David Woodhouse , Brian Norris , Boris BREZILLON , Petros Angelatos , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Hans de Goede Message-ID: <55B79696.40906@redhat.com> Date: Tue, 28 Jul 2015 16:49:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 07/28/2015 04:29 PM, Michal Suchanek wrote: > Hello, > > the NAND chips on Cubietech boards are not known to Linux. > > I used Petros Angelatos' patch from sunxi experimental tree for one chip and > added another chip. > > I hope it's ok to send both patches to avoid merge conflict. I do not think that these patches are a good idea, this will lead to an ever growing manual maintained list of ids, and that is not maintainable IMHO. For Samsung chips we only need the ecc strength and size the rest is already detected on the fly, and I've a patch in my personal tree to get the ecc strengt and size from the nand without needing to have an entry per chip: https://github.com/jwrdegoede/linux-sunxi/commit/53b335d33232753b7aa70298009158baadf5a6bf This is IMHO a much better solution. I've a bunch of nand fixes / cleanups as a result of doing some work on sunxi nand support. I'll try to submit these upstream soon. Regards, Hans