From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754464AbbG3H0G (ORCPT ); Thu, 30 Jul 2015 03:26:06 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:36903 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbbG3H0E (ORCPT ); Thu, 30 Jul 2015 03:26:04 -0400 Subject: Re: [PATCH 4/4] KVM: x86: clean/fix memory barriers in irqchip_in_kernel To: Steve Rutherford References: <1438176538-26191-1-git-send-email-pbonzini@redhat.com> <1438176538-26191-5-git-send-email-pbonzini@redhat.com> <20150730033208.GC15229@google.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, mtosatti@redhat.com, rkrcmar@redhat.com From: Paolo Bonzini Message-ID: <55B9D188.3020600@redhat.com> Date: Thu, 30 Jul 2015 09:26:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150730033208.GC15229@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/2015 05:32, Steve Rutherford wrote: >> > + /* Write kvm->irq_routing before kvm->arch.vpic. */ >> > + smp_wmb(); > I assume this pairs with irqchip_in_kernel? Yes, see the comment added there by this same patch ("read kvm->arch.vpic before kvm->irq_routing"). Paolo