From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH] clk: s5pv210: add missing call to samsung_clk_of_add_provider()
Date: Fri, 07 Aug 2015 16:10:43 +0200 [thread overview]
Message-ID: <55C4BC63.6090203@samsung.com> (raw)
In-Reply-To: <1411117216-11456-1-git-send-email-m.szyprowski@samsung.com>
Hello,
On 2014-09-19 11:00, Marek Szyprowski wrote:
> Commit d5e136a21b2028fb1f45143ea7112d5869bfc6c7 ("clk: samsung: Register
> clk provider only after registering its all clocks", merged to v3.17-rc1)
> modified a way that driver registers registers to core framework. This
> change has not been applied to s5pv210 clocks driver, which has been
> merged in parallel to that commit. This patch adds a missing call to
> samsung_clk_of_add_provider(), so the driver is operational again.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> Hello!
>
> This is an important fix to v3.17-rcX. Without it support for Samsung
> S5PV210 SoCs is not functional.
>
> Mike, could you take it to the fixes branch?
Mike: could you handle this patch? It looks it got missed for a few
releases...
> Best regards
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
> ---
> drivers/clk/samsung/clk-s5pv210.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/samsung/clk-s5pv210.c b/drivers/clk/samsung/clk-s5pv210.c
> index d270a20..f41b017 100644
> --- a/drivers/clk/samsung/clk-s5pv210.c
> +++ b/drivers/clk/samsung/clk-s5pv210.c
> @@ -828,6 +828,8 @@ static void __init __s5pv210_clk_init(struct device_node *np,
>
> s5pv210_clk_sleep_init();
>
> + samsung_clk_of_add_provider(np, ctx);
> +
> pr_info("%s clocks: mout_apll = %ld, mout_mpll = %ld\n"
> "\tmout_epll = %ld, mout_vpll = %ld\n",
> is_s5p6442 ? "S5P6442" : "S5PV210",
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2015-08-07 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 9:00 Marek Szyprowski
2014-09-20 18:20 ` Tomasz Figa
2015-08-07 14:10 ` Marek Szyprowski [this message]
2015-08-08 8:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C4BC63.6090203@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome