From: Shuah Khan <shuahkh@osg.samsung.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Eric B Munson <emunson@akamai.com>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH 1/4] selftests: vm: Fix mlock2-tests for 32-bit architectures
Date: Mon, 10 Aug 2015 13:27:52 -0600 [thread overview]
Message-ID: <55C8FB38.50707@osg.samsung.com> (raw)
In-Reply-To: <1438955055-587-1-git-send-email-thierry.reding@gmail.com>
On 08/07/2015 07:44 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> According to Documentation/vm/pagemap.txt, the /proc/pid/pagemap file
> contains one 64-bit value for each virtual page. The test code relies
> on the size of unsigned long being 64-bit, which breaks the test when
> run on 32-bit architectures. Use a uint64_t to store values read from
> the file instead, so that it works irrespective of the architecture's
> word size.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
Looks good to me. Andrew! Would you like me to take this patch
and the other two in this series through kselftest git?
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
prev parent reply other threads:[~2015-08-10 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 13:44 Thierry Reding
2015-08-07 13:44 ` [PATCH 2/4] selftests: vm: Ensure the mlock2 syscall number can be found Thierry Reding
2015-08-07 13:44 ` [PATCH 3/4] selftests: vm: Use the right arguments for main() Thierry Reding
2015-08-07 13:44 ` [PATCH 4/4] selftests: vm: Pick up sanitized kernel headers Thierry Reding
2015-08-10 19:27 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C8FB38.50707@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=emunson@akamai.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®