From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965315AbbHKPZa (ORCPT ); Tue, 11 Aug 2015 11:25:30 -0400 Received: from lists.s-osg.org ([54.187.51.154]:57189 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965062AbbHKPZ2 (ORCPT ); Tue, 11 Aug 2015 11:25:28 -0400 Subject: Re: [PATCH v3 3/4] mfd: Add DT binding for Maxim MAX77802 IC To: Lee Jones References: <1438252327-28427-1-git-send-email-javier@osg.samsung.com> <1438252327-28427-4-git-send-email-javier@osg.samsung.com> <20150811114736.GB18282@x1> Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sergei Shtylyov , Mark Brown , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <55CA13E1.9090403@osg.samsung.com> Date: Tue, 11 Aug 2015 17:25:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150811114736.GB18282@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Lee, On 08/11/2015 01:47 PM, Lee Jones wrote: > On Thu, 30 Jul 2015, Javier Martinez Canillas wrote: > >> The MAX77802 is a chip that contains regulators, 2 32kHz clocks, >> a RTC and an I2C interface to program the individual components. >> >> The are already DT bindings for the regulators and clocks and >> these reference to a bindings/mfd/max77802.txt file, that didn't >> exist, for the details about the PMIC. >> >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Krzysztof Kozlowski >> >> --- >> >> Changes in v3: >> - Add Krzysztof Kozlowski Reviewed-by tag to patch #3. >> - Capitalise all acronyms. Suggested by Lee Jones. >> - Use relative path to refer other bindings. Suggested by Lee Jones. >> - Use IRQ_TYPE_NONE instead of 0 in example. Suggested by Lee Jones. >> >> Changes in v2: >> - Use the correct "maxim,max77802" compatible string. >> Suggested by Krzysztof Kozlowski >> - Use a pmic generic node name for the max77802 node example. >> Suggested by Sergei Shtylyov. >> >> Documentation/devicetree/bindings/mfd/max77802.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt >> new file mode 100644 >> index 000000000000..911ec5fcaefd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/max77802.txt >> @@ -0,0 +1,26 @@ >> +Maxim MAX77802 multi-function device >> + >> +The Maxim MAX77802 is a Power Management IC (PMIC) that contains 10 high >> +efficiency Buck regulators, 32 Low-DropOut (LDO) regulators used to power >> +up application processors and peripherals, a 2-channel 32kHz clock outputs, >> +a Real-Time-Clock (RTC) and a I2C interface to program the individual >> +regulators, clocks outputs and the RTC. >> + >> +Binding for the built-in 32k clock generator block is defined separately >> +in the ../clk/maxim,max77802.txt file and binding for the regulators >> +is defined in the ../regulator/max77802.txt file. > > "Bindings for the built-in 32k clock generator block and > regulators are defined in ../clk/maxim,max77802.txt and > ../regulator/max77802.txt respectively." > >> +Required properties: >> +- compatible : Must be "maxim,max77802"; > > ';' ? > err... I've no idea how that ended there. It seems I didn't completely context switch from coding :-) >> +- reg : Specifies the I2C slave address of PMIC block. >> +- interrupts : This I2C device has an IRQ line connected to the main SoC. >> +- interrupt-parent : The parent interrupt controller. > > I always find this easier on the eye when you: > > Required properties: > - compatible : Must be "maxim,max77802" > - reg : Specifies the I2C slave address of PMIC block. > - interrupts : This I2C device has an IRQ line connected to the main SoC. > - interrupt-parent : The parent interrupt controller. > Ok, I'll wait for Mark's feedback and repost with your suggestions. Thanks! >> +Example: >> + >> + max77802: pmic@09 { >> + compatible = "maxim,max77802"; >> + interrupt-parent = <&intc>; >> + interrupts = <26 IRQ_TYPE_NONE>; >> + reg = <0x09>; >> + }; > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America