From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753073AbbHKSnd (ORCPT ); Tue, 11 Aug 2015 14:43:33 -0400 Received: from smtp-out-194.synserver.de ([212.40.185.194]:1151 "EHLO smtp-out-194.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752264AbbHKSnb (ORCPT ); Tue, 11 Aug 2015 14:43:31 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 12713 Message-ID: <55CA424F.1030704@metafoo.de> Date: Tue, 11 Aug 2015 20:43:27 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Joe Perches , devel@driverdev.osuosl.org, Michael Hennerich CC: Jonathan Cameron , Hartmut Knaack , Peter Meerwald , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/19] staging: iio: Remove unnecessary externs References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2015 11:51 PM, Joe Perches wrote: > Using 'extern' is not necessary for function prototypes. > > Signed-off-by: Joe Perches Acked-by: Lars-Peter Clausen Thanks. > --- > drivers/staging/iio/meter/ade7854.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/meter/ade7854.h b/drivers/staging/iio/meter/ade7854.h > index 52ca541..52f4195 100644 > --- a/drivers/staging/iio/meter/ade7854.h > +++ b/drivers/staging/iio/meter/ade7854.h > @@ -168,7 +168,7 @@ struct ade7854_state { > > }; > > -extern int ade7854_probe(struct iio_dev *indio_dev, struct device *dev); > -extern int ade7854_remove(struct iio_dev *indio_dev); > +int ade7854_probe(struct iio_dev *indio_dev, struct device *dev); > +int ade7854_remove(struct iio_dev *indio_dev); > > #endif >