Re: [PATCH V8 03/25] perf tools: Add Intel PT instruction decoder

[Adrian Hunter <adrian.hunter@intel.com>]

On 12/08/15 23:55, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jul 17, 2015 at 07:33:38PM +0300, Adrian Hunter escreveu:
>> Add support for decoding instructions for Intel Processor Trace.  The
>> kernel x86 instruction decoder is copied for this.
>>
>> This essentially provides intel_pt_get_insn() which takes a binary
>> buffer, uses the kernel's x86 instruction decoder to get details of the
>> instruction and then categorizes it for consumption by an Intel PT
>> decoder.
> 
> 
> [acme@felicio linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make -C tools/perf O=/tmp/build/perf install-bin
> make: Entering directory `/home/acme/git/linux/tools/perf'
>   BUILD:   Doing 'make -j4' parallel build
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libunwind: [ on  ]
> ...            libdw-dwarf-unwind: [ on  ]
> ...                          zlib: [ on  ]
> ...                          lzma: [ on  ]
> 
> <SNIP>
> 
>   CC       /tmp/build/perf/util/thread-stack.o
>   MKDIR    /tmp/build/perf/ui/tui/
>   CC       /tmp/build/perf/ui/tui/setup.o
>   CC       /tmp/build/perf/util/auxtrace.o
>   MKDIR    /tmp/build/perf/ui/browsers/
>   MKDIR    /tmp/build/perf/util/intel-pt-decoder/
>   CC       /tmp/build/perf/ui/browsers/hists.o
>   CC       /tmp/build/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.o
>   MKDIR    /tmp/build/perf/ui/tui/
>   CC       /tmp/build/perf/ui/tui/util.o
>   GEN      /tmp/build/perf/util/intel-pt-decoder/inat-tables.c
>   MKDIR    /tmp/build/perf/util/scripting-engines/
>   CC       /tmp/build/perf/util/scripting-engines/trace-event-perl.o
>   CC       /tmp/build/perf/util/intel-pt-decoder/intel-pt-insn-decoder.o
>   CC       /tmp/build/perf/ui/tui/helpline.o
>   CC       /tmp/build/perf/ui/browsers/map.o
>   CC       /tmp/build/perf/ui/browsers/scripts.o
>   CC       /tmp/build/perf/ui/tui/progress.o
>   MKDIR    /tmp/build/perf/util/scripting-engines/
>   CC       /tmp/build/perf/util/scripting-engines/trace-event-python.o
> util/intel-pt-decoder/intel-pt-insn-decoder.c:26:18: fatal error: insn.c: No such file or directory
>  #include <insn.c>
>                   ^
> compilation terminated.

I had a fix for this already but for some reason it fell in with the "for
later" patches.

I will roll the fix in and send V9 of this patch.