mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@plumgrid.com>
To: pi3orama <pi3orama@163.com>
Cc: He Kuang <hekuang@huawei.com>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"masami.hiramatsu.pt@hitachi.com"
	<masami.hiramatsu.pt@hitachi.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"wangnan0@huawei.com" <wangnan0@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v6 0/2] Make eBPF programs output data to perf
Date: Thu, 13 Aug 2015 14:49:34 -0700	[thread overview]
Message-ID: <55CD10EE.7000300@plumgrid.com> (raw)
In-Reply-To: <3DE5423D-3E4E-4395-846D-7D5EAD1BB911@163.com>

On 8/13/15 2:35 PM, pi3orama wrote:
> I was thinking about whether to add a "type" field there, so we will have an explicit
> mov const instruction before the call instruction, which can act as a mark. Also, if
> we generate the type code automatically, a type field in this API can make things
> easier since we don't need wrap the user structure in BPF stack. However, the
> LLVM side is not ready yet, so we haven't post the new version.

I think the helper was clean enough. Any type info probably needs to be
done as a side channel and not part of the helper anyway.
But, ok, let's figure out the type stuff first.
Also I don't think you can rely on extra insn in front of a call insn.
Compiler can freely insert other insns there. You don't want to
introduce data flow analysis in elf parser.


  reply	other threads:[~2015-08-13 21:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21  3:08 He Kuang
2015-07-21  3:08 ` [RFC PATCH v6 1/2] tools lib traceevent: Support function __get_dynamic_array_len He Kuang
2015-07-21 15:08   ` Namhyung Kim
2015-07-21  3:08 ` [RFC PATCH v6 2/2] bpf: Introduce function for outputing data to perf event He Kuang
2015-07-21 15:13   ` Namhyung Kim
2015-08-13 21:27 ` [RFC PATCH v6 0/2] Make eBPF programs output data to perf Alexei Starovoitov
2015-08-13 21:35   ` pi3orama
2015-08-13 21:49     ` Alexei Starovoitov [this message]
2015-08-19  3:05       ` Wangnan (F)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CD10EE.7000300@plumgrid.com \
    --to=ast@plumgrid.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pi3orama@163.com \
    --cc=rostedt@goodmis.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome