From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752527AbbHQD2z (ORCPT ); Sun, 16 Aug 2015 23:28:55 -0400 Received: from mga14.intel.com ([192.55.52.115]:5848 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbbHQD2y (ORCPT ); Sun, 16 Aug 2015 23:28:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,692,1432623600"; d="scan'208";a="749856421" Subject: Re: [PATCH v3 1/6] genirq: fix irq_chip_retrigger_hierarchy To: Grygorii Strashko , tglx@linutronix.de, tony@atomide.com, marc.zyngier@arm.com References: <1439554830-19502-1-git-send-email-grygorii.strashko@ti.com> <1439554830-19502-2-git-send-email-grygorii.strashko@ti.com> Cc: linux@arm.linux.org.uk, nsekhar@ti.com, jason@lakedaemon.net, balbi@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sudeep Holla From: Jiang Liu Organization: Intel Message-ID: <55D154EF.1070500@linux.intel.com> Date: Mon, 17 Aug 2015 11:28:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1439554830-19502-2-git-send-email-grygorii.strashko@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/8/14 20:20, Grygorii Strashko wrote: > Now irq_chip_retrigger_hierarchy() returns -ENOSYS if it > was not able to find at least one .irq_retrigger() callback > implemented in IRQ domain hierarchy. As result, IRQ > re-triggering is not working now on ARM (TI OMAP) where > ARM GIC is not implemented this callback. > The .irq_retrigger() is optional (see check_irq_resend()) > and there are no reasons to fail if it was not found, hence > lets return 0 in this case. > > In case of TI OMAP DRA7 the following IRQ hierarchy is defined: > ARM GIC <- OMAP wakeupgen <- TI CBAR > > Failure is reproduced during resume from suspend to RAM: > - wakeup by IRQx > - suspend_enter > + arch_suspend_enable_irqs > + handle_fasteoi_irq > + irq_may_run > + irq_pm_check_wakeup > + irq_disable(IRQx) > + dpm_resume_noirq() > + resume_device_irqs > + resume_irqs > + resume_irq > + __enable_irq <== IRQx is not re-triggered > > Cc: Sudeep Holla > Cc: Jiang Liu > Fixes: 85f08c17de26 ('genirq: Introduce helper functions...') > Reviewed-by: Marc Zyngier > Signed-off-by: Grygorii Strashko > --- > kernel/irq/chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c > index 27f4332..6de638b 100644 > --- a/kernel/irq/chip.c > +++ b/kernel/irq/chip.c > @@ -997,7 +997,7 @@ int irq_chip_retrigger_hierarchy(struct irq_data *data) > if (data->chip && data->chip->irq_retrigger) > return data->chip->irq_retrigger(data); > > - return -ENOSYS; > + return 0; > } > > /** Hi Grygorii, Thanks for fixing this regression:) Reviewed-by: Jiang Liu