From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbbHRH5m (ORCPT ); Tue, 18 Aug 2015 03:57:42 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:33610 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbbHRH5k (ORCPT ); Tue, 18 Aug 2015 03:57:40 -0400 X-AuditID: cbfec7f5-f794b6d000001495-1b-55d2e5712eb2 Message-id: <55D2E569.3000800@samsung.com> Date: Tue, 18 Aug 2015 16:57:29 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Javier Martinez Canillas , Kukjin Kim Cc: Geert Uytterhoeven , Doug Anderson , Olof Johansson , Gwendal Grignou , Sjoerd Simons , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver References: <1439881281-22054-1-git-send-email-javier@osg.samsung.com> In-reply-to: <1439881281-22054-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4Zd3Cp5dCDU7OV7c4u+wgm8WzW3uZ LGYvPspi8ebtGiaL1y8MLfofv2a22PT4GqvF5V1z2CxmnN/HZHHq+mc2i+nH37I6cHvMbrjI 4vH3+XUWj02rOtk8Dh3uYPTYvKTe48qJJlaPLf132T36tqxi9Pi8SS6AM4rLJiU1J7MstUjf LoEr40z3UuaCLTwVj6+cZWxg3MrVxcjJISFgIvF53gJ2CFtM4sK99WwgtpDAUkaJK9sMuxi5 gOwvjBLH/1xhBEnwCmhJrF3QxgJiswioSrxYdgIsziZgLLF5+RKwZlGBCInlq09C1QtK/Jh8 D6xeRCBMYm77QVaQocwCe5kk7nVMAksIC8RKPH+0mhVis5tEz9WzYHFOAXeJrnmtQNdxADXo Sdy/qAUSZhaQl9i85i3zBEaBWUhWzEKomoWkagEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT8 3E2MkHj5uoNx6TGrQ4wCHIxKPLwVeZdChVgTy4orcw8xSnAwK4nw6qcChXhTEiurUovy44tK c1KLDzFKc7AoifPO3PU+REggPbEkNTs1tSC1CCbLxMEp1cDYtH9xXhhLm83yieK9oYL7ZPk+ Cu5/0t7HmPns1IsPFXf6pobPUj9eMWep+1kD+c3K924t3eZyftf7phaP1Djn9svJU5maXZ9e +lbecllA/KqozaxgsUj/c6yTzt8TFnTWsuht//la3ucfT9zu7zWVk11tF5arC378I+1/OvbR /m9/tX6EPLqjxFKckWioxVxUnAgAp2t2wJMCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.08.2015 16:01, Javier Martinez Canillas wrote: > The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config > symbol because the driver uses some communication helper functions in > drivers/platform/chrome/cros_ec_proto.c but other drivers depends on > CROS_EC_PROTO instead. Mixing select and depends can lead to circular > Kconfig dependencies so the MFD_CROS_EC select should be changed to a > depends on CROS_EC_PROTO instead. > > But doing so will break git bisect-ability since MFD_CROS_EC will not > be enabled anymore unless the default configs first explicitly enable > the CROS_EC_PROTO dependency. > > Signed-off-by: Javier Martinez Canillas > --- > arch/arm/configs/exynos_defconfig | 1 + > 1 file changed, 1 insertion(+) I saw the discussion about circular dependency but I wasn't following it. Currently the CROS_EC_PROTO is not user-selectable. How can you depend on it? How can be enabled on different configs (customized by user)? Maybe the questions are answered by code in different patches? Best regards, Krzysztof > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 1ff2bfa2e183..537391ea37ac 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -177,6 +177,7 @@ CONFIG_DMADEVICES=y > CONFIG_PL330_DMA=y > CONFIG_CHROME_PLATFORMS=y > CONFIG_CROS_EC_CHARDEV=y > +CONFIG_CROS_EC_PROTO=y > CONFIG_COMMON_CLK_MAX77686=y > CONFIG_COMMON_CLK_MAX77802=y > CONFIG_COMMON_CLK_S2MPS11=y >