From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbbHRIJn (ORCPT ); Tue, 18 Aug 2015 04:09:43 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:26605 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbbHRIJk (ORCPT ); Tue, 18 Aug 2015 04:09:40 -0400 X-AuditID: cbfec7f5-f794b6d000001495-9f-55d2e8410147 Message-id: <55D2E83D.70206@samsung.com> Date: Tue, 18 Aug 2015 17:09:33 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Javier Martinez Canillas , Kukjin Kim Cc: Geert Uytterhoeven , Doug Anderson , Olof Johansson , Gwendal Grignou , Sjoerd Simons , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver References: <1439881281-22054-1-git-send-email-javier@osg.samsung.com> <55D2E569.3000800@samsung.com> <55D2E767.50807@osg.samsung.com> In-reply-to: <55D2E767.50807@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42I5/e/4ZV3HF5dCDV590LQ4u+wgm8WzW3uZ LGYvPspi8ebtGiaL1y8MLfofv2a22PT4GqvF5V1z2CxmnN/HZHHq+mc2i+nH37I6cHvMbrjI 4vH3+XUWj02rOtk8Dh3uYPTYvKTe48qJJlaPLf132T36tqxi9Pi8SS6AM4rLJiU1J7MstUjf LoEr4+fEz6wF2/grXr9azNbAeJGni5GDQ0LAROJGX10XIyeQKSZx4d56ti5GLg4hgaWMEr/W XINyvjBKNB1dzAJSxSugIbFp8RQ2EJtFQFXiwooOJhCbTcBYYvPyJWBxUYEIieWrTzJC1AtK /Jh8D6xXRCBMYm77QVaQocwCe5kk7nVMAksIC8RKPH+0mhViWwejRPuED6wgCU4BXYmXrZ/Y QE5lFtCTuH9RCyTMLCAvsXnNW+YJjAKzkOyYhVA1C0nVAkbmVYyiqaXJBcVJ6blGesWJucWl eel6yfm5mxghEfN1B+PSY1aHGAU4GJV4eCvyLoUKsSaWFVfmHmKU4GBWEuHVTwUK8aYkVlal FuXHF5XmpBYfYpTmYFES5525632IkEB6YklqdmpqQWoRTJaJg1OqgXH/kWLprpMSwq27bq3x 2t3m7PfzipPYQWOZsBPOC6zmCAWfjltz/cWXlDfLNdhuJnzo+rL8uXn/25eJH1yueu59q7+4 7Ejhm2dp0atnfhTL2mz4cF3rTOUMr5mfr/e3C2Tt7F/EIRnDMEvWOKCi3rmovD34pMdRxn9l W0XKJas4qmcfUluyQkiJpTgj0VCLuag4EQB0VEHmlAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.08.2015 17:05, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 08/18/2015 09:57 AM, Krzysztof Kozlowski wrote: >> On 18.08.2015 16:01, Javier Martinez Canillas wrote: >>> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config >>> symbol because the driver uses some communication helper functions in >>> drivers/platform/chrome/cros_ec_proto.c but other drivers depends on >>> CROS_EC_PROTO instead. Mixing select and depends can lead to circular >>> Kconfig dependencies so the MFD_CROS_EC select should be changed to a >>> depends on CROS_EC_PROTO instead. >>> >>> But doing so will break git bisect-ability since MFD_CROS_EC will not >>> be enabled anymore unless the default configs first explicitly enable >>> the CROS_EC_PROTO dependency. >>> >>> Signed-off-by: Javier Martinez Canillas >>> --- >>> arch/arm/configs/exynos_defconfig | 1 + >>> 1 file changed, 1 insertion(+) >> >> I saw the discussion about circular dependency but I wasn't following >> it. Currently the CROS_EC_PROTO is not user-selectable. How can you >> depend on it? How can be enabled on different configs (customized by user)? >> >> Maybe the questions are answered by code in different patches? > > Yes, that's why I posted "[PATCH] platform/chrome: Make CROS_EC_PROTO > a user selectable option" [0]. > > I posted as separate patches because there isn't a dependency between > them and once all the defconfig patches and the patch to make the > CROS_EC_PROTO symbol user selectable lands, I'll post the patch to > change select for depends on to avoid a regression. Makes sense now. Reviewed-by: Krzysztof Kozlowski > > Maybe I should had posted as a series (or at least cc all the people > in all the patches) to not left these questions unanswered... Yep, Cc-ing or a short cover letter would probably answer my question. :) Best regards, Krzysztof