From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Nicholas Mc Guire <hofrat@osadl.org>,
Russell King <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>, Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Thierry Reding <treding@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-mapping: harmonize definition of DMA_ERROR_CODE
Date: Tue, 18 Aug 2015 10:10:16 +0200 [thread overview]
Message-ID: <55D2E868.2030609@samsung.com> (raw)
In-Reply-To: <1433925694-12865-1-git-send-email-hofrat@osadl.org>
Hello,
On 2015-06-10 10:41, Nicholas Mc Guire wrote:
> All architectures except arm that define DMA_ERROR_CODE are casting it
> to (dma_addr_t) - as it is always compared to dma_addr_t in arm as well
> this could be harmonized.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>
> This also fixes the build warning in
> ./arch/arm/include/asm/dma-mapping.h: In function 'dma_mapping_error':
> ./arch/arm/include/asm/dma-mapping.h:176:18: warning: comparison between
> signed and unsigned integer expressions [-Wsign-compare]
>
> While it fixes this build warning it causes another build warning - so
> from that perspective its not much of an improvement - never the less
> having this harmonized with all other archs makes sense I think.
>
> Patch was compile tested with exynos_defconfig
>
> Patch is against 4.1-rc7 (localversion-next is -next-20150609)
>
> arch/arm/include/asm/dma-mapping.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> index b52101d..68e41e8 100644
> --- a/arch/arm/include/asm/dma-mapping.h
> +++ b/arch/arm/include/asm/dma-mapping.h
> @@ -14,7 +14,7 @@
> #include <xen/xen.h>
> #include <asm/xen/hypervisor.h>
>
> -#define DMA_ERROR_CODE (~0)
> +#define DMA_ERROR_CODE (~(dma_addr_t)0x0)
> extern struct dma_map_ops arm_dma_ops;
> extern struct dma_map_ops arm_coherent_dma_ops;
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
prev parent reply other threads:[~2015-08-18 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 8:41 Nicholas Mc Guire
2015-08-18 8:10 ` Marek Szyprowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D2E868.2030609@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=stefano.stabellini@eu.citrix.com \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome