From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Linus Walleij <linus.walleij@linaro.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: syscon: Correct check for syscon_node_to_regmap() errors
Date: Tue, 18 Aug 2015 12:35:23 +0200 [thread overview]
Message-ID: <55D30A6B.5060304@samsung.com> (raw)
In-Reply-To: <1439828334-6619-1-git-send-email-bjorn.andersson@sonymobile.com>
Hi Bjor,
On 08/17/2015 06:18 PM, Bjorn Andersson wrote:
> syscon_node_to_regmap() returns a regmap or an ERR_PTR().
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
> drivers/leds/leds-syscon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c
> index d1660b039812..39fca4c9f1ee 100644
> --- a/drivers/leds/leds-syscon.c
> +++ b/drivers/leds/leds-syscon.c
> @@ -83,7 +83,7 @@ static int syscon_led_probe(struct platform_device *pdev)
> return -ENODEV;
> }
> map = syscon_node_to_regmap(parent->of_node);
> - if (!map) {
> + if (IS_ERR(map)) {
> dev_err(dev, "no regmap for syscon LED parent\n");
> return -ENODEV;
return PTR_ERR(map) ?
> }
>
--
Best Regards,
Jacek Anaszewski
prev parent reply other threads:[~2015-08-18 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 16:18 Bjorn Andersson
2015-08-18 10:35 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D30A6B.5060304@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=cooloney@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome