mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>, hch@infradead.org
Cc: ed.cashin@acm.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] block: Reinstate BLK_DEF_MAX_SECTORS
Date: Tue, 18 Aug 2015 13:22:03 -0700	[thread overview]
Message-ID: <55D393EB.7020506@kernel.dk> (raw)
In-Reply-To: <1439492277-14638-1-git-send-email-jmoyer@redhat.com>

On 08/13/2015 11:57 AM, Jeff Moyer wrote:
> Commit 34b48db66e08 (block: remove artificial max_hw_sectors cap)
> caused performance regressions for streaming I/O workloads across
> a range of storage from SATA disks to enterprise storage arrays.
> I was unable to actually show a performance gain for any storage
> I have access to.  However, the patch was introduced to boost
> performance on software RAID over SATA disks, and I don't have
> access to such a configuration.
>
> The compromise is to reinstate BLK_DEF_MAX_SECTORS, but to bump it
> up to 2560 from 1024.  This number should allow full stripe writes
> to 10 data disks with a chunk size of 128KB, and at the same time
> does not regress the storage I have access to.
>
> [PATCH 1/2] Revert "block: remove artifical max_hw_sectors cap"
> [PATCH 2/2] block: bump BLK_DEF_MAX_SECTORS to 2560

Thanks, I added both. A bit annoying though, but better to fix up the 
perf regression now.

-- 
Jens Axboe


      parent reply	other threads:[~2015-08-18 20:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 18:57 Jeff Moyer
2015-08-13 18:57 ` [PATCH 1/2] Revert "block: remove artifical max_hw_sectors cap" Jeff Moyer
2015-08-15  1:18   ` Ed Cashin
2015-08-13 18:57 ` [PATCH 2/2] block: bump BLK_DEF_MAX_SECTORS to 2560 Jeff Moyer
2015-08-18 20:22 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D393EB.7020506@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=ed.cashin@acm.org \
    --cc=hch@infradead.org \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome