From: "Nick Wang" <nwang@suse.com>
To: "Lars Ellenberg" <lars.ellenberg@linbit.com>
Cc: "Philipp Reisner" <philipp.reisner@linbit.com>,
<drbd-dev@lists.linbit.com>, <linux-kernel@vger.kernel.org>
Subject: 答复: Re: [PATCH] drbd: Support zeroout device instead of initial full sync
Date: Thu, 20 Aug 2015 21:26:09 -0600 [thread overview]
Message-ID: <55D70AD10200007000065BF8@relay2.provo.novell.com> (raw)
In-Reply-To: <20150818150319.GL19958@soda.linbit>
Hi Lars,
> I still think this does not belong into the kernel at all.
> I may not yet have properly explained why.
>
Thanks for your information.
I tried blkdiscard on my test machine, but unfortunately the
underlying block device i used doesn't support discard...
(/sys/block/<dev>/queue/discard_max_bytes == 0)
However, i think blkscard could work well for SSDs and
thinly-provisioned support storage as a workaround.
> This is a lot of stuff to add to the DRBD module,
> introducing write protocol incompatibility/protocol version bump.
>
> For no good reason.
>
Yes, it is not a mandatory feature, more like a enhancement
"convenience patch" for some edge cases. User can choose
zeroout/discard devices via drbd tools, in case the storage
does not support discard, it will using zeroout instead of only
throw an "not support" error to output.
Implement this function to drbd also help to sync the status
between nodes, convenience for auto deploy or monitor by admin.
Also have the possibility to implement a resume broken
zeroout/discard in future.
And i can understand your concern and any decision, many thanks
for your and Philipp's help and review:)
Best regards,
Nick
prev parent reply other threads:[~2015-08-21 3:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 8:38 [Patch v2 00/10] Zero out devices " Nick Wang
2015-07-13 8:38 ` [Patch v2 01/10] drbd: Fix the wrong logic of moving history Nick Wang
2015-07-13 8:38 ` [Patch v2 02/10] drbd: Add option zap_devices to new-current-uuid Nick Wang
2015-07-31 12:50 ` [Drbd-dev] " Philipp Reisner
2015-07-13 8:38 ` [Patch v2 03/10] drbd: A function to zero out drbd backing device Nick Wang
2015-07-13 8:38 ` [Patch v2 04/10] drbd: New packet P_ZERO_OUT Nick Wang
2015-07-13 8:38 ` [Patch v2 05/10] drbd: Functions to notify peer node to zero out Nick Wang
2015-07-13 8:39 ` [Patch v2 06/10] drbd: Wapper for zeroing out device by worker Nick Wang
2015-07-13 8:39 ` [Patch v2 07/10] drbd: Flags for background drbd device work Nick Wang
2015-07-13 8:39 ` [Patch v2 08/10] drbd: Function to work with packet P_ZERO_OUT Nick Wang
2015-07-13 8:39 ` [Patch v2 09/10] drbd: Handle zero out command from peer node Nick Wang
2015-07-13 8:39 ` [Patch v2 10/10] drbd: Handle new-current-uuid --zap-devices Nick Wang
2015-07-31 12:48 ` [Drbd-dev] [Patch v2 00/10] Zero out devices instead of initial full sync Philipp Reisner
2015-08-06 10:04 ` [PATCH v3 0/1] Zeroout/discard " Nick Wang
2015-08-06 10:04 ` [PATCH] drbd: Support zeroout device " Nick Wang
2015-08-18 15:03 ` Lars Ellenberg
2015-08-21 3:26 ` Nick Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D70AD10200007000065BF8@relay2.provo.novell.com \
--to=nwang@suse.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®