From: "Jan Beulich" <JBeulich@suse.com>
To: "Alexander Kuleshov" <kuleshovmail@gmail.com>
Cc: "Andy Lutomirski" <luto@amacapital.net>, <x86@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Denys Vlasenko" <dvlasenk@redhat.com>,
"Ingo Molnar" <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/calling.h: remove unused SAVE_ALL/RESTORE_ALL macro for !CONFIG_x86_64
Date: Mon, 24 Aug 2015 05:09:20 -0600 [thread overview]
Message-ID: <55DB1780020000780009CA7D@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1440184368-26602-1-git-send-email-kuleshovmail@gmail.com>
>>> On 21.08.15 at 21:12, <kuleshovmail@gmail.com> wrote:
> SAVE_ALL and RESTORE_ALL macros for !CONFIG_X86_64 were introduced in the
> 1a338ac32 commit (sched, x86: Optimize the preempt_schedule() call) and
> were used in the ___preempt_schedule and ___preempt_schedule_context from
> the arch/x86/kernel/preempt.S. But the arch/x86/kernel/preempt.S was
> removed in the 0ad6e3c5 commit (x86: Speed up ___preempt_schedule*() by
> using THUNK helpers) and ___preempt_schedule/___preempt_schedule_context
> are reimplemeted and not used SAVE_ALL/RESTORE_ALL anymore.
>
> These macros have no users anymore, so we can remove it.
As far as the description goes this is fine, but ...
> --- a/arch/x86/entry/calling.h
> +++ b/arch/x86/entry/calling.h
> @@ -46,8 +46,6 @@ For 32-bit we have the following conventions - kernel is built with
>
> */
>
> -#ifdef CONFIG_X86_64
... why do you remove this conditional, thus exposing x86-64-only
definitions to ix86 code?
Jan
prev parent reply other threads:[~2015-08-24 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 19:12 Alexander Kuleshov
2015-08-24 11:09 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DB1780020000780009CA7D@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®