From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933212AbbHZUHU (ORCPT ); Wed, 26 Aug 2015 16:07:20 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:54955 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbbHZUHS (ORCPT ); Wed, 26 Aug 2015 16:07:18 -0400 Message-ID: <55DE1C73.7070000@roeck-us.net> Date: Wed, 26 Aug 2015 13:07:15 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Jeremy Linton , Steve Glendinning CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tony@atomide.com" Subject: Re: [RFC PATCH] smsc911x: Ignore error return from device_get_phy_mode() References: <1440614948-27428-1-git-send-email-linux@roeck-us.net> <55DE1735.3070106@arm.com> In-Reply-To: <55DE1735.3070106@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/26/2015 12:44 PM, Jeremy Linton wrote: > On 08/26/2015 01:49 PM, Guenter Roeck wrote: >> Check the return value from device_property_read_u32() to see if there >> is a suitable firmware interface to read the data, and abort if not. >> The function should return -ENXIO in that case; however, it returns >> -ENODATA. Check for both. >> >> Fixes: 62ee783bf1f8 ("smsc911x: Fix crash seen if neither ACPI nor OF is configured or used") >> Signed-off-by: Guenter Roeck >> --- >> Needs testing. RFC because I am not sure if the -ENODATA check is acceptable. > > I'm not really sure about it myself. I can think of cases where it might cause problems. That said it does work in an ACPI environment with or without the _DSD block. If the DSD/property isn't set, obviously the device doesn't configure (but it doesn't crash either) so that is good and an overall improvement for ACPI. > > Also, I personally might have hoisted the reg-io-width ahead of the device_get_phy_mode() and removed the phy checks, but I don't imagine there is much functional difference at this point. > > Tested-by: Jeremy Linton > I'll post a separate two-patch series which introduces -ENXIO as return value. Guenter