From: Robert Baldyga <r.baldyga@samsung.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: clement.perrochaud@effinnov.com, linux-kernel@vger.kernel.org,
sameo@linux.intel.com, linux-nfc@ml01.01.org
Subject: Re: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags
Date: Mon, 31 Aug 2015 10:02:40 +0200 [thread overview]
Message-ID: <55E40A20.9040003@samsung.com> (raw)
In-Reply-To: <55E4082D.5090805@samsung.com>
[ +cc Samuel Ortiz and <linux-nfc@lists.01.org> ]
Hi Samuel,
Could you please apply this patch?
Thanks,
Robert
On 08/31/2015 09:54 AM, Robert Baldyga wrote:
> On 08/25/2015 10:50 AM, Valentin Rothberg wrote:
>> NFC_DEBUG is not defined in Kconfig and since DEBUG is not used
>> anywhere in this directory, we can safely remove this line.
>>
>> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
>
> Acked-by: Robert Baldyga <r.baldyga@samsung.com>
>
> Thanks,
> Robert Baldyga
>
>> ---
>> I detected the issue with scripts/checkkconfigsymbols.py
>>
>> drivers/nfc/s3fwrn5/Makefile | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/nfc/s3fwrn5/Makefile b/drivers/nfc/s3fwrn5/Makefile
>> index 3381c34faf62..ddfa7be7dd05 100644
>> --- a/drivers/nfc/s3fwrn5/Makefile
>> +++ b/drivers/nfc/s3fwrn5/Makefile
>> @@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o
>>
>> obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
>> obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
>> -
>> -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
>>
>
next prev parent reply other threads:[~2015-08-31 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 8:50 Valentin Rothberg
2015-08-31 7:54 ` Robert Baldyga
2015-08-31 8:02 ` Robert Baldyga [this message]
2015-10-06 23:44 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E40A20.9040003@samsung.com \
--to=r.baldyga@samsung.com \
--cc=clement.perrochaud@effinnov.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@ml01.01.org \
--cc=sameo@linux.intel.com \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome