From: "Wangnan (F)" <wangnan0@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>, Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, <mingo@kernel.org>,
<ast@plumgrid.com>, <linux-kernel@vger.kernel.org>,
<lizefan@huawei.com>, <pi3orama@163.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 02/31] perf tools: Don't set cmdline_group_boundary if no evsel is collected
Date: Tue, 1 Sep 2015 20:44:42 +0800 [thread overview]
Message-ID: <55E59DBA.1000709@huawei.com> (raw)
In-Reply-To: <20150901103848.GE12968@krava.brq.redhat.com>
On 2015/9/1 18:38, Jiri Olsa wrote:
> On Mon, Aug 31, 2015 at 04:20:03PM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Sat, Aug 29, 2015 at 04:21:36AM +0000, Wang Nan escreveu:
>>> If parse_events__scanner() collects no entry, perf_evlist__last(evlist)
>>> is invalid. Then setting of cmdline_group_boundary touches invalid.
>>>
>>> It could happend in currect BPF implementation. See [1]. Although it
>>> can be fixed, for safety reason it whould be better to introduce this
>>> check.
>>>
>>> Instead of checking number of entries, check data.list instead, so we
>>> can add dummy evsel here.
>> Event parsing fixes should have Jiri Olsa on the CC list, Jiri, is this
>> ok?
>>
>> From what I can see it looks Ok, my question, just from looking at this
>> patch, is if it is valid to get to this point with an empty data.list,
>> i.e. was it ever possible and this is a bug irrespective of eBPF?
> good point, I believe it's either fail or event(s) added to the list
> I haven't checked how's eBPF connected with event parsing, is there a
> git tree I could check?
Please check:
https://git.kernel.org/cgit/linux/kernel/git/pi3orama/linux.git/log/?h=perf/ebpf
commit d7d91228cad0a78eae5ea9526a8a78debf3cf584
commit 2606fe61219899cb386823eddc1bc231ff5067a6
related to parsing.
Thank you.
> thanks,
> jirka
next prev parent reply other threads:[~2015-09-01 12:49 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 4:21 [GIT PULL 00/31] perf tools: filtering events using eBPF programs Wang Nan
2015-08-29 4:21 ` [PATCH 01/31] bpf tools: New API to get name from a BPF object Wang Nan
2015-08-29 4:21 ` [PATCH 02/31] perf tools: Don't set cmdline_group_boundary if no evsel is collected Wang Nan
2015-08-31 19:20 ` Arnaldo Carvalho de Melo
2015-09-01 10:37 ` Wangnan (F)
2015-09-01 10:38 ` Jiri Olsa
2015-09-01 12:44 ` Wangnan (F) [this message]
2015-09-02 2:53 ` [PATCH] perf tools: Don't set leader if parser doesn't collect an evsel Wang Nan
2015-09-02 3:01 ` Wangnan (F)
2015-09-02 5:57 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-02 6:09 ` Wangnan (F)
[not found] ` <1441176553-116129-1-git-send-email-wangnan0@huawei.com>
2015-09-02 6:53 ` [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel Wangnan (F)
2015-09-02 10:31 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-02 11:54 ` Jiri Olsa
2015-09-02 12:05 ` pi3orama
2015-09-02 12:46 ` Jiri Olsa
2015-09-02 13:55 ` Arnaldo Carvalho de Melo
2015-09-02 14:04 ` pi3orama
2015-09-02 14:43 ` Arnaldo Carvalho de Melo
2015-09-02 22:24 ` pi3orama
2015-08-29 4:21 ` [PATCH 03/31] perf tools: Introduce dummy evsel Wang Nan
2015-08-31 19:38 ` Arnaldo Carvalho de Melo
2015-09-03 0:11 ` Namhyung Kim
2015-09-03 0:42 ` pi3orama
2015-09-06 5:55 ` [PATCH] perf tools: Allow BPF placeholder dummy events to collect --filter options Wang Nan
2015-09-06 5:56 ` [PATCH] perf tools: Sync setting of real bpf events with placeholder Wang Nan
2015-08-29 4:21 ` [PATCH 04/31] perf tools: Make perf depend on libbpf Wang Nan
2015-08-29 4:21 ` [PATCH 05/31] perf ebpf: Add the libbpf glue Wang Nan
2015-08-29 4:21 ` [PATCH 06/31] perf tools: Enable passing bpf object file to --event Wang Nan
2015-08-29 4:21 ` [PATCH 07/31] perf probe: Attach trace_probe_event with perf_probe_event Wang Nan
2015-09-02 4:32 ` Namhyung Kim
2015-09-02 5:40 ` Wangnan (F)
2015-08-29 4:21 ` [PATCH 08/31] perf record, bpf: Parse and probe eBPF programs probe points Wang Nan
2015-08-29 4:21 ` [PATCH 09/31] perf bpf: Collect 'struct perf_probe_event' for bpf_program Wang Nan
2015-08-29 4:21 ` [PATCH 10/31] perf record: Load all eBPF object into kernel Wang Nan
2015-08-29 4:21 ` [PATCH 11/31] perf tools: Add bpf_fd field to evsel and config it Wang Nan
2015-08-29 4:21 ` [PATCH 12/31] perf tools: Allow filter option to be applied to bof object Wang Nan
2015-08-29 4:21 ` [PATCH 13/31] perf tools: Attach eBPF program to perf event Wang Nan
2015-08-29 4:21 ` [PATCH 14/31] perf tools: Suppress probing messages when probing by BPF loading Wang Nan
2015-09-03 0:20 ` Namhyung Kim
2015-09-03 2:42 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-03 12:10 ` [PATCH perf/core ] perf-probe: Output the result of adding/deleting probe in buildin-probe Masami Hiramatsu
2015-09-03 12:18 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-03 17:25 ` Namhyung Kim
2015-09-03 20:28 ` Arnaldo Carvalho de Melo
2015-09-04 1:30 ` 平松雅巳 / HIRAMATU，MASAMI
2015-08-29 4:21 ` [PATCH 15/31] perf record: Add clang options for compiling BPF scripts Wang Nan
2015-08-29 4:21 ` [PATCH 16/31] perf tools: Infrastructure for compiling scriptlets when passing '.c' to --event Wang Nan
2015-08-29 4:21 ` [PATCH 17/31] perf tests: Enforce LLVM test for BPF test Wang Nan
2015-09-01 5:59 ` Wangnan (F)
2015-08-29 4:21 ` [PATCH 18/31] perf test: Add 'perf test BPF' Wang Nan
2015-09-02 12:45 ` Namhyung Kim
2015-09-05 12:21 ` Wang Nan
2015-08-29 4:21 ` [PATCH 19/31] bpf tools: Load a program with different instances using preprocessor Wang Nan
2015-08-29 4:21 ` [PATCH 20/31] perf probe: Reset args and nargs for probe_trace_event when failure Wang Nan
2015-08-29 4:21 ` [PATCH 21/31] perf tools: Move linux/filter.h to tools/include Wang Nan
2015-08-31 20:35 ` Arnaldo Carvalho de Melo
2015-09-01 19:39 ` Arnaldo Carvalho de Melo
2015-09-01 19:47 ` Arnaldo Carvalho de Melo
2015-09-01 21:08 ` pi3orama
2015-09-01 21:43 ` Arnaldo Carvalho de Melo
2015-09-08 14:31 ` [tip:perf/core] perf tools: Copy " tip-bot for He Kuang
2015-08-29 4:21 ` [PATCH 22/31] perf tools: Add BPF_PROLOGUE config options for further patches Wang Nan
2015-08-31 20:39 ` Arnaldo Carvalho de Melo
2015-09-01 6:59 ` Wang Nan
2015-09-01 6:59 ` [PATCH 23/31] perf tools: Introduce regs_query_register_offset() for x86 Wang Nan
2015-09-01 11:47 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-01 13:52 ` Wangnan (F)
2015-09-01 14:50 ` Arnaldo Carvalho de Melo
2015-09-01 14:14 ` Arnaldo Carvalho de Melo
2015-09-01 15:54 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-06 6:02 ` Wangnan (F)
2015-09-06 6:04 ` [PATCH] perf test: Enforce LLVM test, add kbuild test Wang Nan
2015-09-06 6:04 ` [PATCH] perf test: Test BPF prologue Wang Nan
2015-09-02 14:08 ` [PATCH 22/31] perf tools: Add BPF_PROLOGUE config options for further patches Namhyung Kim
2015-08-29 4:21 ` [PATCH 23/31] perf tools: Introduce arch_get_reg_info() for x86 Wang Nan
2015-08-31 20:43 ` Arnaldo Carvalho de Melo
2015-09-01 2:39 ` Wangnan (F)
2015-08-29 4:21 ` [PATCH 24/31] perf tools: Add prologue for BPF programs for fetching arguments Wang Nan
2015-08-29 4:21 ` [PATCH 25/31] perf tools: Generate prologue for BPF programs Wang Nan
2015-08-29 4:22 ` [PATCH 26/31] perf tools: Use same BPF program if arguments are identical Wang Nan
2015-08-29 4:22 ` [PATCH 27/31] perf record: Support custom vmlinux path Wang Nan
2015-09-01 20:19 ` Arnaldo Carvalho de Melo
2015-09-01 20:21 ` Arnaldo Carvalho de Melo
2015-09-01 21:00 ` pi3orama
2015-09-01 21:33 ` Arnaldo Carvalho de Melo
2015-08-29 4:22 ` [PATCH 28/31] perf probe: Init symbol as kprobe Wang Nan
2015-09-01 20:11 ` Arnaldo Carvalho de Melo
2015-09-02 1:22 ` Wangnan (F)
2015-09-02 1:38 ` 平松雅巳 / HIRAMATU，MASAMI
2015-08-29 4:22 ` [PATCH 29/31] perf tools: Support attach BPF program on uprobe events Wang Nan
2015-08-29 4:22 ` [PATCH 30/31] perf tools: Fix cross compiling error Wang Nan
2015-08-29 4:22 ` [PATCH 31/31] tools lib traceevent: Support function __get_dynamic_array_len Wang Nan
2015-09-08 14:31 ` [tip:perf/core] " tip-bot for He Kuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E59DBA.1000709@huawei.com \
--to=wangnan0@huawei.com \
--cc=acme@redhat.com \
--cc=ast@plumgrid.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome