From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932648AbbIDA0g (ORCPT ); Thu, 3 Sep 2015 20:26:36 -0400 Received: from lists.s-osg.org ([54.187.51.154]:34083 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752269AbbIDA0f (ORCPT ); Thu, 3 Sep 2015 20:26:35 -0400 Subject: Re: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 To: Krzysztof Kozlowski , Anand Moon , Russell King , Kukjin Kim , Andreas Faerber , Lukasz Majewski , Sjoerd Simons References: <1441303910-3266-1-git-send-email-linux.amoon@gmail.com> <55E8DDDD.80106@samsung.com> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <55E8E534.1040204@osg.samsung.com> Date: Fri, 4 Sep 2015 02:26:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <55E8DDDD.80106@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 09/04/2015 01:55 AM, Krzysztof Kozlowski wrote: > On 04.09.2015 03:11, Anand Moon wrote: >> Earlier design of the LED for Odroid XU3 was using gpio-leds >> Now It was change to using both pwm-leds and gpio-leds. > > It is still not a reason for this change. gpio-leds were not enabled > before. This could be a valid reason of adding LEDS_PWM to existing > config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on > the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO? > Agreed, also the commit message doesn't explain why the heartbeat LED trigger is enabled as I mentioned in the previous version. > Actually I gave up on this and I wanted to change the commit message on > myself when applying. But discussion was brought up again so... clearly > we have different understanding of the meaning of "WHY". :) > > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America