From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753803AbbIGHta (ORCPT ); Mon, 7 Sep 2015 03:49:30 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:50087 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753533AbbIGHtZ (ORCPT ); Mon, 7 Sep 2015 03:49:25 -0400 X-AuditID: cbfec7f5-f794b6d000001495-1d-55ed41830be4 Message-id: <55ED4182.4000806@samsung.com> Date: Mon, 07 Sep 2015 09:49:22 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Muhammad Falak R Wani Cc: Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: leds-hp6xx: Use devm_led_classdev_register References: <1441482817-23400-1-git-send-email-falakreyaz@gmail.com> In-reply-to: <1441482817-23400-1-git-send-email-falakreyaz@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t/xa7rNjm9DDf6vEbY4unMik8Xuh+dZ LS7vmsNmsfXNOkaL3buesjqweuycdZfdY8/8H6wenzfJBTBHcdmkpOZklqUW6dslcGW8Xt3P WtDDUvF1ZwdLA+M65i5GTg4JAROJt/NPM0LYYhIX7q1n62Lk4hASWMoosWnzT2YI5xmjxPGO H+wgVbwCWhIN62axdjFycLAIqEq8+68OEmYTMJT4+eI1E4gtKhAh8ef0PlaIckGJH5PvsYCU iwgYSHz+FAgSZhZoZJTobRUBsYUFXCV+zNgHdoOQgIvEnRsXWUBsTqD4p7mLmSHqrSVWTtrG CGHLS2xe85Z5AqPALCQbZiEpm4WkbAEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkND9 uoNx6TGrQ4wCHIxKPLw3ut6ECrEmlhVX5h5ilOBgVhLhNdkCFOJNSaysSi3Kjy8qzUktPsQo zcGiJM47c9f7ECGB9MSS1OzU1ILUIpgsEwenVAOj4VaF0j7z6PVCVrVzPwn3++n3rixWOVNY 9zqxt22R0NmTX19y2jrn7fHjODkntfFWhJgil9Z6/k1buPL3XeO6LW7CaBswIS7e/8SvxkaH uxtCM9Wv3iySjH/6MHyT7KlzIedKr36vWbzt3Omb2xw2TOfn/Pf83KMOfnnzxe66Lk76y0Rn cK5XYinOSDTUYi4qTgQAyB/zLFkCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/2015 09:53 PM, Muhammad Falak R Wani wrote: > Use resource-managed function devm_led_classdev_register > instead of led_classdev_register to simplify error path. > An unnecessary check of ret is replaced with a direct return > Also, remove redundant hp6xxled_remove. > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/leds/leds-hp6xx.c | 17 ++--------------- > 1 file changed, 2 insertions(+), 15 deletions(-) > Merged, thanks. -- Best Regards, Jacek Anaszewski