From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753616AbbIKMbg (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Sep 2015 08:31:36 -0400
Received: from lucky1.263xmail.com ([211.157.147.133]:37500 "EHLO
	lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753500AbbIKMbd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Sep 2015 08:31:33 -0400
X-263anti-spam: KSV:0;
X-MAIL-GRAY: 1
X-MAIL-DELIVERY: 0
X-KSVirus-check: 0
X-ABS-CHECKED: 4
X-ADDR-CHECKED: 0
X-RL-SENDER: shawn.lin@rock-chips.com
X-FST-TO: olof@lixom.net
X-SENDER-IP: 58.22.7.114
X-LOGIN-NAME: shawn.lin@rock-chips.com
X-UNIQUE-TAG: <1d9d87c5896317c5bfcad0f5719de9c9>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Subject: Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1
To: Mark Brown <broonie@kernel.org>
References: <1441501881-13700-1-git-send-email-shawn.lin@rock-chips.com>
 <1441502008-14116-1-git-send-email-shawn.lin@rock-chips.com>
 <20150911115331.GM12027@sirena.org.uk>
Cc: shawn.lin@rock-chips.com, Vinod Koul <vinod.koul@intel.com>,
        Heiko Stuebner <heiko@sntech.de>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Doug Anderson <dianders@chromium.org>,
        Olof Johansson <olofj@google.com>, Sonny Rao <sonnyrao@chromium.org>,
        Addy Ke <addy.ke@rock-chips.com>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
        linux-spi@vger.kernel.org, Yiwei Cai <cain.cai@rock-chips.com>,
        Jianqun Xu <xjq@rock-chips.com>, Olof Johansson <olof@lixom.net>
From: Shawn Lin <shawn.lin@rock-chips.com>
Message-ID: <55F2C994.4040007@rock-chips.com>
Date: Fri, 11 Sep 2015 20:31:16 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150911115331.GM12027@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

在 2015/9/11 19:53, Mark Brown 写道:
> On Sun, Sep 06, 2015 at 09:13:28AM +0800, Shawn Lin wrote:
>
>> @@ -460,7 +463,6 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>>   	i2s->playback_dma_data.addr = res->start + I2S_TXDR;
>>   	i2s->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
>>   	i2s->playback_dma_data.maxburst = 4;
>> -
>>   	i2s->capture_dma_data.addr = res->start + I2S_RXDR;
>>   	i2s->capture_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
>>   	i2s->capture_dma_data.maxburst = 4;
>
> This random whitespace change shouldn't be in here.

yes, sorry for this bit.

>
>> @@ -489,6 +491,18 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>>   		goto err_pcm_register;
>>   	}
>>
>> +	dma_quirk = snd_dmaengine_pcm_get_quirks(&pdev->dev);
>> +	if (dma_quirk == ROCKCHIP_I2S_BROKEN_BURST_LEN) {
>> +		/*
>
> I'd expect this to be a switch statement given the way this is written.

Ahh.. agreed, but we don't expect more quriks for this driver.  ：）)))
Will be done for the next version.

Thanks.

>


-- 
Best Regards
Shawn Lin