From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbbINGZ5 (ORCPT ); Mon, 14 Sep 2015 02:25:57 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:64361 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbbINGZ4 (ORCPT ); Mon, 14 Sep 2015 02:25:56 -0400 Message-ID: <55F6684F.4010007@huawei.com> Date: Mon, 14 Sep 2015 14:25:19 +0800 From: Xishi Qiu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Ingo Molnar , Peter Zijlstra , Andrew Morton , CC: Linux MM , LKML Subject: [PATCH] numa-balancing: fix confusion in /proc/sys/kernel/numa_balancing Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.25.179] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We can only echo 0 or 1 > "/proc/sys/kernel/numa_balancing", usually 1 means enable and 0 means disable. But when echo 1, it shows the value is 65536, this is confusion. Signed-off-by: Xishi Qiu --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 3595403..e97a348 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -2135,7 +2135,7 @@ int sysctl_numa_balancing(struct ctl_table *table, int write, { struct ctl_table t; int err; - int state = numabalancing_enabled; + int state = !!numabalancing_enabled; if (write && !capable(CAP_SYS_ADMIN)) return -EPERM; -- 2.0.0