From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbbIOLtd (ORCPT ); Tue, 15 Sep 2015 07:49:33 -0400 Received: from lists.s-osg.org ([54.187.51.154]:36278 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbbIOLtR (ORCPT ); Tue, 15 Sep 2015 07:49:17 -0400 Subject: Re: [PATCH] spi: mediatek: fix wrong error return value on probe To: Mark Brown References: <1441320656-8666-1-git-send-email-javier@osg.samsung.com> <20150914183925.GG12027@sirena.org.uk> Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <55F805B7.7020706@osg.samsung.com> Date: Tue, 15 Sep 2015 13:49:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150914183925.GG12027@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, On 09/14/2015 08:39 PM, Mark Brown wrote: > On Fri, Sep 04, 2015 at 12:50:56AM +0200, Javier Martinez Canillas wrote: >> Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") >> added a new sel_clk but introduced bugs in the error paths since >> the wrong struct clk pointers are passed to PTR_ERR(). > > This doesn't apply against current code, please check and resend. > Which branch should I use as a baseline then? The patch applies cleanly on both today's linux-next (next-20150915) and your for-linus branch: https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/log/?h=for-linus Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America