From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752944AbbIPLue (ORCPT ); Wed, 16 Sep 2015 07:50:34 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:39681 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbbIPLuc (ORCPT ); Wed, 16 Sep 2015 07:50:32 -0400 X-Helo: d06dlp03.portsmouth.uk.ibm.com X-MailFrom: borntraeger@de.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm To: Tejun Heo References: <55F81EE2.4090708@de.ibm.com> <55F84A6B.1010207@redhat.com> <55F88991.7040406@de.ibm.com> <20150915212622.GC495@htj.duckdns.org> <20150915213830.GR4029@linux.vnet.ibm.com> <20150915222811.GD495@htj.duckdns.org> <20150915233818.GU4029@linux.vnet.ibm.com> <20150916012415.GC25658@htj.duckdns.org> <55F91DDB.6070207@de.ibm.com> <55F94B38.5060308@de.ibm.com> <20150916110351.GA17047@htj.duckdns.org> Cc: "Paul E. McKenney" , Paolo Bonzini , Peter Zijlstra , Ingo Molnar , "linux-kernel@vger.kernel.org >> Linux Kernel Mailing List" , KVM list , Oleg Nesterov From: Christian Borntraeger Message-ID: <55F95784.8070608@de.ibm.com> Date: Wed, 16 Sep 2015 13:50:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150916110351.GA17047@htj.duckdns.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15091611-0025-0000-0000-000006E104BE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 16.09.2015 um 13:03 schrieb Tejun Heo: > Hello, > > On Wed, Sep 16, 2015 at 12:58:00PM +0200, Christian Borntraeger wrote: >> FWIW, I added a printk to percpu_down_write. With KVM and uprobes disabled, >> just booting up a fedora20 gives me __6749__ percpu_down_write calls on 4.2. >> systemd seems to do that for the processes. >> >> So a revert is really the right thing to do. In fact, I dont know if the >> rcu_sync_enter rework is enough. With systemd setting the cgroup seem to >> be NOT a cold/seldom case. > > Booting would usually be the hottest operation for that and it's still > *relatively* cold path compared to the reader side which is task > fork/exit paths. The whole point is shift overhead from hotter reader > side. Can you see problems with percpu_rwsem rework? As I said, it seems the rcu tree with that change seems to work fine on my system. This needs a more testing on other machines, though. I guess a revert plus a re-add in the 4.4 merge window should give us enough test coverage. Christian