From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568AbbIPOep (ORCPT ); Wed, 16 Sep 2015 10:34:45 -0400 Received: from e06smtp05.uk.ibm.com ([195.75.94.101]:47838 "EHLO e06smtp05.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752580AbbIPOen (ORCPT ); Wed, 16 Sep 2015 10:34:43 -0400 X-Helo: d06dlp01.portsmouth.uk.ibm.com X-MailFrom: borntraeger@de.ibm.com X-RcptTo: linux-s390@vger.kernel.org Subject: Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage) To: "Jason J. Herne" , pbonzini@redhat.com References: <1442409230-10806-1-git-send-email-jjherne@linux.vnet.ibm.com> Cc: cornelia.huck@de.ibm.com, peterz@infradead.org, tglx@linutronix.de, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org From: Christian Borntraeger Message-ID: <55F97DFA.80709@de.ibm.com> Date: Wed, 16 Sep 2015 16:34:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442409230-10806-1-git-send-email-jjherne@linux.vnet.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15091614-0021-0000-0000-0000041BBCA4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 16.09.2015 um 15:13 schrieb Jason J. Herne: > The offending commit accidentally replaces an atomic_clear with an > atomic_or instead of an atomic_andnot in kvm_s390_vcpu_request_handled. > The symptom is that kvm guests on s390 hang on startup. > This patch simply replaces the incorrect atomic_or with atomic_andnot > > Signed-off-by: Jason J. Herne Acked-by: Christian Borntraeger Paolo, can you take this via kvm tree for 4.3? Maybe move the subject line into the mail body an rephrase the subject line. Christian > --- > arch/s390/kvm/kvm-s390.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index c91eb94..49e76be 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -1574,7 +1574,7 @@ static void kvm_s390_vcpu_request(struct kvm_vcpu *vcpu) > > static void kvm_s390_vcpu_request_handled(struct kvm_vcpu *vcpu) > { > - atomic_or(PROG_REQUEST, &vcpu->arch.sie_block->prog20); > + atomic_andnot(PROG_REQUEST, &vcpu->arch.sie_block->prog20); > } > > /* >