From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752557AbbIPO4B (ORCPT ); Wed, 16 Sep 2015 10:56:01 -0400 Received: from resqmta-po-01v.sys.comcast.net ([96.114.154.160]:56006 "EHLO resqmta-po-01v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbbIPOz7 (ORCPT ); Wed, 16 Sep 2015 10:55:59 -0400 X-Greylist: delayed 493 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Sep 2015 10:55:59 EDT Subject: Re: [PATCH] [SCSI] FlashPoint: fix build warning To: Sudip Mukherjee , "James E.J. Bottomley" References: <1442412380-1832-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org From: Khalid Aziz Message-ID: <55F9810F.6030004@gonehiking.org> Date: Wed, 16 Sep 2015 08:47:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442412380-1832-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/16/2015 08:06 AM, Sudip Mukherjee wrote: > We have been getting a warning about non ANSI function. > warning: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll' > > Signed-off-by: Sudip Mukherjee > --- > drivers/scsi/FlashPoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c > index 5c74e4c..867b864 100644 > --- a/drivers/scsi/FlashPoint.c > +++ b/drivers/scsi/FlashPoint.c > @@ -2136,7 +2136,7 @@ static unsigned char FPT_SccbMgr_bad_isr(u32 p_port, unsigned char p_card, > * > *---------------------------------------------------------------------*/ > > -static void FPT_SccbMgrTableInitAll() > +static void FPT_SccbMgrTableInitAll(void) > { > unsigned char thisCard; > > Acked-by: Khalid Aziz James, please apply this to your SCSI tree. -- Khalid