From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754493AbbIQIk1 (ORCPT ); Thu, 17 Sep 2015 04:40:27 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:53582 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754210AbbIQIkY (ORCPT ); Thu, 17 Sep 2015 04:40:24 -0400 X-AuditID: cbfee68d-f79106d00000728c-ee-55fa7c76683d Message-id: <55FA7A76.2080705@samsung.com> Date: Thu, 17 Sep 2015 14:01:50 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: amit daniel kachhap Cc: linux-scsi@vger.kernel.org, "linux-kernel@vger.kernel.org" , vinholikatti@gmail.com, JBottomley@odin.com, essuuj@gmail.com Subject: Re: [PATCH 07/10] scsi: ufs: add add specific callback for hibern8 References: <1440149281-26336-1-git-send-email-alim.akhtar@samsung.com> <1440149281-26336-8-git-send-email-alim.akhtar@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsWyRsSkVres5leowfYb4hYNV0Msll9YwmTx f/1tFovLu+awWXRf38FmsWNhlQObx85Zd9k9Dv/4wezRt2UVo8fnTXIBLFFcNimpOZllqUX6 dglcGb9/BxS8VK/4cHgRYwPjYrkuRk4OCQETiXfXTrJA2GISF+6tZ+ti5OIQEljBKDF7VR9T FyMHWNGRp0wQ8aWMEktXNTNCOA8YJWadf8QK0s0roCXx/NJ/dpAGFgFViTtzJUHCbALaEnen bwGbIyoQIfH4ghBEtaDEj8n3WEDCIgKGErO+i4NMZBZYwCjx/eQ+JpAaYQFviUtfP0GtOsMo sfjZNHaQBKdAsMS8syvBipgFzCQetaxjhrDlJTavecsM0iAhcIhdYvvK+WwgCRYBAYlvkw+x QDwjK7HpADPEw5ISB1fcYJnAKDYLyU2zkIydhWTsAkbmVYyiqQXJBcVJ6UWGesWJucWleel6 yfm5mxiBsXX637PeHYy3D1gfYhTgYFTi4VVw+RUqxJpYVlyZe4jRFOiKicxSosn5wAjOK4k3 NDYzsjA1MTU2Mrc0UxLnVZT6GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qBkWmyzaYfMSK3 kszksjcv170ZmRl4advaRfPMtWyEau28cmomf0lzLdc5JTOpxlP1001j24gphg3Oasu9y6p2 OT+0nzY/50ievp4M57QQThUeU0HmTS6cqZHc7xtWPIyZku4kt+nUN5Ulk0MeWse+YGPs+rdK fvYK7hrFVXr5GUqm3jOZpq1WYinOSDTUYi4qTgQAtYfCK6gCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrEIsWRmVeSWpSXmKPExsVy+t9jAd2yml+hBkteC1g0XA2xWH5hCZPF //W3WSwu75rDZtF9fQebxY6FVQ5sHjtn3WX3OPzjB7NH35ZVjB6fN8kFsEQ1MNpkpCampBYp pOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAO1WUihLzCkFCgUkFhcr 6dthmhAa4qZrAdMYoesbEgTXY2SABhLWMGb8/h1Q8FK94sPhRYwNjIvluhg5OCQETCSOPGXq YuQEMsUkLtxbz9bFyMUhJLCUUWLpqmZGCOcBo8Ss849YQap4BbQknl/6zw7SzCKgKnFnriRI mE1AW+Lu9C1MIGFRgQiJxxeEIKoFJX5MvscCEhYRMJSY9V0cZCKzwAJGie8n94HtFRbwlrj0 9RPUqjOMEoufTWMHSXAKBEvMO7sSrIhZwEziUcs6ZghbXmLzmrfMExgFZiHZMQtJ2SwkZQsY mVcxSqQWJBcUJ6XnGuallusVJ+YWl+al6yXn525iBMfvM6kdjAd3uR9iFOBgVOLhVXD5FSrE mlhWXJl7iFGCg1lJhJclGyjEm5JYWZValB9fVJqTWnyI0RQYBhOZpUST84GpJa8k3tDYxNzU 2NTSxMLEzFJJnFd25bNQIYH0xJLU7NTUgtQimD4mDk6pBsbLHhsW7y220taQUlTWrqmx7z+0 85D4LN63S53n3hNXKsv+5vTvSp6sIfOhxt83Dy3xmJ97NPu6Udp/PePp5bNedSnoO8afPnzC L/7WwceLnCbdzpZu/FL8aJevR33DbNHDO+68Dli+UTm9/MtRD5ns/a+Ep+zZ8441p9/2m6zi txMf4kIYHk5XYinOSDTUYi4qTgQAqWPy1vUCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Amit, On 08/26/2015 11:51 AM, amit daniel kachhap wrote: > On Fri, Aug 21, 2015 at 2:57 PM, Alim Akhtar wrote: >> From: Seungwon Jeon >> >> Some host controller needs specific handling before/after >> (un)hibernation, This change adds specific callback function >> to support vendor's implementation. >> >> Signed-off-by: Seungwon Jeon >> Signed-off-by: Alim Akhtar >> --- >> drivers/scsi/ufs/ufshcd.c | 36 ++++++++++++++++++++++++++++++++---- >> drivers/scsi/ufs/ufshcd.h | 3 +++ >> 2 files changed, 35 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index bc27f5e..d425ea1 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi/ufs/ufshcd.c >> @@ -181,8 +181,7 @@ static int ufshcd_probe_hba(struct ufs_hba *hba); >> static int __ufshcd_setup_clocks(struct ufs_hba *hba, bool on, >> bool skip_ref_clk); >> static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on); >> -static int ufshcd_uic_hibern8_exit(struct ufs_hba *hba); >> -static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba); >> +static int ufshcd_uic_hibern8_ctrl(struct ufs_hba *hba, bool en); >> static inline void ufshcd_add_delay_before_dme_cmd(struct ufs_hba *hba); >> static int ufshcd_host_reset_and_restore(struct ufs_hba *hba); >> static irqreturn_t ufshcd_intr(int irq, void *__hba); >> @@ -215,6 +214,16 @@ static inline void ufshcd_disable_irq(struct ufs_hba *hba) >> } >> } >> >> +static inline int ufshcd_uic_hibern8_enter(struct ufs_hba *hba) >> +{ >> + return ufshcd_uic_hibern8_ctrl(hba, true); >> +} >> + >> +static inline int ufshcd_uic_hibern8_exit(struct ufs_hba *hba) >> +{ >> + return ufshcd_uic_hibern8_ctrl(hba, false); >> +} >> + >> /* >> * ufshcd_wait_for_register - wait for register value to change >> * @hba - per-adapter interface >> @@ -2395,7 +2404,7 @@ out: >> return ret; >> } >> >> -static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba) >> +static int __ufshcd_uic_hibern8_enter(struct ufs_hba *hba) >> { >> struct uic_command uic_cmd = {0}; >> >> @@ -2404,7 +2413,7 @@ static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba) >> return ufshcd_uic_pwr_ctrl(hba, &uic_cmd); >> } >> >> -static int ufshcd_uic_hibern8_exit(struct ufs_hba *hba) >> +static int __ufshcd_uic_hibern8_exit(struct ufs_hba *hba) >> { >> struct uic_command uic_cmd = {0}; >> int ret; >> @@ -2419,6 +2428,25 @@ static int ufshcd_uic_hibern8_exit(struct ufs_hba *hba) >> return ret; >> } >> >> +static int ufshcd_uic_hibern8_ctrl(struct ufs_hba *hba, bool en) >> +{ >> + int ret; >> + >> + if (hba->vops && hba->vops->hibern8_notify) >> + hba->vops->hibern8_notify(hba, en, PRE_CHANGE); > Return of hibern8_notify is not checked. Otherwise make the return type void. ok will change. >> + >> + ret = en ? __ufshcd_uic_hibern8_enter(hba) : >> + __ufshcd_uic_hibern8_exit(hba); >> + if (ret) >> + goto out; >> + >> + if (hba->vops && hba->vops->hibern8_notify) >> + hba->vops->hibern8_notify(hba, en, POST_CHANGE); >> + >> +out: >> + return ret; >> +} >> + >> /** >> * ufshcd_init_pwr_info - setting the POR (power on reset) >> * values in hba power info >> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h >> index 0b7dde0..045968e 100644 >> --- a/drivers/scsi/ufs/ufshcd.h >> +++ b/drivers/scsi/ufs/ufshcd.h >> @@ -260,6 +260,8 @@ struct ufs_pwr_mode_info { >> * @specify_nexus_t_xfer_req: >> * @specify_nexus_t_tm_req: called before command is issued to allow vendor >> * specific handling to be set for nexus type. >> + * @hibern8_notify: called before and after hibernate/unhibernate is carried out >> + * to allow vendor spesific implementation. >> * @suspend: called during host controller PM callback >> * @resume: called during host controller PM callback >> */ >> @@ -276,6 +278,7 @@ struct ufs_hba_variant_ops { >> int (*pwr_change_notify)(struct ufs_hba *, >> bool, struct ufs_pa_layer_attr *, >> struct ufs_pa_layer_attr *); >> + int (*hibern8_notify)(struct ufs_hba *, bool, bool); >> void (*specify_nexus_t_xfer_req)(struct ufs_hba *, >> int, struct scsi_cmnd *); >> void (*specify_nexus_t_tm_req)(struct ufs_hba *, int, u8); >> -- >> 1.7.10.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >