From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754357AbbIQIlk (ORCPT ); Thu, 17 Sep 2015 04:41:40 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:60390 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753698AbbIQIlh (ORCPT ); Thu, 17 Sep 2015 04:41:37 -0400 X-AuditID: cbfee690-f796f6d000005054-bc-55fa7cbfc70b Message-id: <55FA7ABF.1020607@samsung.com> Date: Thu, 17 Sep 2015 14:03:03 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: amit daniel kachhap Cc: linux-scsi@vger.kernel.org, "linux-kernel@vger.kernel.org" , vinholikatti@gmail.com, JBottomley@odin.com, essuuj@gmail.com Subject: Re: [PATCH 08/10] scsi: ufs: make ufshcd_config_pwr_mode of non-static func References: <1440149281-26336-1-git-send-email-alim.akhtar@samsung.com> <1440149281-26336-9-git-send-email-alim.akhtar@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsWyRsSkVnd/za9Qg9U/lC0aroZYLL+whMni //rbLBaXd81hs+i+voPNYsfCKgc2j52z7rJ7HP7xg9mjb8sqRo/Pm+QCWKK4bFJSczLLUov0 7RK4Mv7PXMtSsFO8YvmaB8wNjIeEuhg5OSQETCS+vN3ICmGLSVy4t56ti5GLQ0hgBaPEy4/z 2GCKPt7cxwqRWMoo8bfhPAuE84BR4szzI4wgVbwCWhJHt/1kBrFZBFQlDq+axgRiswloS9yd vgXI5uAQFYiQeHxBCKJcUOLH5HssIGERAUOJWd/FQUYyCyxglPh+ch9Yq7BAmMTM/Q+ZIXad YZS4+vMl2KmcAsESHw59AbuOWcBM4lHLOmYIW15i85q3YA0SAofYJRZdnA51kIDEt8mHwLZJ CMhKbDrADPGZpMTBFTdYJjCKzUJy0ywkY2chGbuAkXkVo2hqQXJBcVJ6kYlecWJucWleul5y fu4mRmCEnf73bMIOxnsHrA8xCnAwKvHwKrj8ChViTSwrrsw9xGgKdMVEZinR5HxgHOeVxBsa mxlZmJqYGhuZW5opifO+lvoZLCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoGR54n32+2SmXpO m7L0LtoG2rGuypLMs9io8/Diuz8mP2fN2n7jpu+vx14b75z2fT9hwkqRy11/rE5l5HLMea+y /OrBMxFhnB8Lt+q9O9p6c232dBPX4y3ZXfvObHkuxmApFN10kiNKT67mcS3be5WNlxz9RZTk 9aqO7rw2x1/n/IRfO6MEWmovKbEUZyQaajEXFScCAGIj1RurAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsVy+t9jAd39Nb9CDY41ylo0XA2xWH5hCZPF //W3WSwu75rDZtF9fQebxY6FVQ5sHjtn3WX3OPzjB7NH35ZVjB6fN8kFsEQ1MNpkpCampBYp pOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAO1WUihLzCkFCgUkFhcr 6dthmhAa4qZrAdMYoesbEgTXY2SABhLWMGb8n7mWpWCneMXyNQ+YGxgPCXUxcnJICJhIfLy5 jxXCFpO4cG89WxcjF4eQwFJGib8N51kgnAeMEmeeH2EEqeIV0JI4uu0nM4jNIqAqcXjVNCYQ m01AW+Lu9C1ANgeHqECExOMLQhDlghI/Jt9jAQmLCBhKzPouDjKSWWABo8T3k/vAWoUFwiRm 7n/IDLHrDKPE1Z8vwS7iFAiW+HDoCxuIzSxgJvGoZR0zhC0vsXnNW+YJjAKzkOyYhaRsFpKy BYzMqxglUguSC4qT0nMN81LL9YoTc4tL89L1kvNzNzGCo/iZ1A7Gg7vcDzEKcDAq8fAquPwK FWJNLCuuzD3EKMHBrCTCy5INFOJNSaysSi3Kjy8qzUktPsRoCgyEicxSosn5wASTVxJvaGxi bmpsamliYWJmqSTOK7vyWaiQQHpiSWp2ampBahFMHxMHp1QDY/OXFQuOqvLar7acJPJnCmNN gdXN5QwPHY7IX/0SW5hwbaqYxw4Lk+oud6Mjq7w+iwsYlodOXZnnLXzapnj92VNn1RZoehde m9su8srxwr4a07o8szeufw4bcHeze27g5/28gNdPq3BF0/yIU0t+zt2fZLjg8IKVLxb8/BK4 TuX92VOyc20CSpVYijMSDbWYi4oTATHkjw/4AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Amit, On 08/26/2015 11:53 AM, amit daniel kachhap wrote: > On Fri, Aug 21, 2015 at 2:57 PM, Alim Akhtar wrote: >> From: Seungwon Jeon >> >> It can be used in the vendor's driver for the specific purpose. > more description of this log will be useful. >> Will reword. Thanks >> Signed-off-by: Seungwon Jeon >> Signed-off-by: Alim Akhtar >> --- >> drivers/scsi/ufs/ufshcd.c | 5 ++--- >> drivers/scsi/ufs/ufshcd.h | 2 ++ >> 2 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index d425ea1..8982da9 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi/ufs/ufshcd.c >> @@ -185,8 +185,6 @@ static int ufshcd_uic_hibern8_ctrl(struct ufs_hba *hba, bool en); >> static inline void ufshcd_add_delay_before_dme_cmd(struct ufs_hba *hba); >> static int ufshcd_host_reset_and_restore(struct ufs_hba *hba); >> static irqreturn_t ufshcd_intr(int irq, void *__hba); >> -static int ufshcd_config_pwr_mode(struct ufs_hba *hba, >> - struct ufs_pa_layer_attr *desired_pwr_mode); >> static int ufshcd_change_power_mode(struct ufs_hba *hba, >> struct ufs_pa_layer_attr *pwr_mode); >> >> @@ -2597,7 +2595,7 @@ static int ufshcd_change_power_mode(struct ufs_hba *hba, >> * @hba: per-adapter instance >> * @desired_pwr_mode: desired power configuration >> */ >> -static int ufshcd_config_pwr_mode(struct ufs_hba *hba, >> +int ufshcd_config_pwr_mode(struct ufs_hba *hba, >> struct ufs_pa_layer_attr *desired_pwr_mode) >> { >> struct ufs_pa_layer_attr final_params = { 0 }; >> @@ -2613,6 +2611,7 @@ static int ufshcd_config_pwr_mode(struct ufs_hba *hba, >> >> return ret; >> } >> +EXPORT_SYMBOL_GPL(ufshcd_config_pwr_mode); >> >> /** >> * ufshcd_complete_dev_init() - checks device readiness >> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h >> index 045968e..13368e1 100644 >> --- a/drivers/scsi/ufs/ufshcd.h >> +++ b/drivers/scsi/ufs/ufshcd.h >> @@ -636,6 +636,8 @@ extern int ufshcd_dme_set_attr(struct ufs_hba *hba, u32 attr_sel, >> u8 attr_set, u32 mib_val, u8 peer); >> extern int ufshcd_dme_get_attr(struct ufs_hba *hba, u32 attr_sel, >> u32 *mib_val, u8 peer); >> +extern int ufshcd_config_pwr_mode(struct ufs_hba *hba, >> + struct ufs_pa_layer_attr *desired_pwr_mode); >> >> /* UIC command interfaces for DME primitives */ >> #define DME_LOCAL 0 >> -- >> 1.7.10.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >