From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754439AbbIQImT (ORCPT ); Thu, 17 Sep 2015 04:42:19 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:39082 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbbIQImQ (ORCPT ); Thu, 17 Sep 2015 04:42:16 -0400 X-AuditID: cbfee68e-f79c56d000006efb-5d-55fa7ce61725 Message-id: <55FA7AE6.3000801@samsung.com> Date: Thu, 17 Sep 2015 14:03:42 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: amit daniel kachhap Cc: linux-scsi@vger.kernel.org, "linux-kernel@vger.kernel.org" , vinholikatti@gmail.com, JBottomley@odin.com, essuuj@gmail.com Subject: Re: [PATCH 09/10] scsi: ufs: return value of pwr_change_notify References: <1440149281-26336-1-git-send-email-alim.akhtar@samsung.com> <1440149281-26336-10-git-send-email-alim.akhtar@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsWyRsSkWvdZza9Qg8mHNC0aroZYLL+whMni //rbLBaXd81hs+i+voPNYsfCKgc2j52z7rJ7HP7xg9mjb8sqRo/Pm+QCWKK4bFJSczLLUov0 7RK4MhatuMxU0CFece7Rf6YGxh/8XYwcHBICJhJnWtK6GDmBTDGJC/fWs4HYQgIrGCWaj4pB xE0k7r/Zyt7FyAUUn8UoMfvrPWYI5wGjROep66wgVbwCWhKH501nArFZBFQl3k2dA2azCWhL 3J2+hQlkmahAhMTjC0IQ5YISPybfYwEJiwgYSsz6Lg4ykllgAaPE95P7wMqFBdwlru8xgFh1 llFi09mlYMdxCgRL3JjXzAhiMwuYSTxqWccMYctLbF7zFuw2CYFD7BJntsxghbhHQOLb5EMs EA/LSmw6wAzxmKTEwRU3WCYwis1CctIsJGNnIRm7gJF5FaNoakFyQXFSepGRXnFibnFpXrpe cn7uJkZgbJ3+96xvB+PNA9aHGAU4GJV4eBVcfoUKsSaWFVfmHmI0BbpiIrOUaHI+MILzSuIN jc2MLExNTI2NzC3NlMR5E6R+BgsJpCeWpGanphakFsUXleakFh9iZOLglGpgNNv0uOXh6i17 qy1nP12bkcyUYdliv7L0yZn3Cms4WjMkdU1OPgzwefJc7QNHFeeefWFrfa73Ctx457eWx0LK bPtCZ/PkBJftr5bX5zx71Sa1Nv+rhMvy8NhJF0+YZfE4m3SWeGpPXHfELt2/PffHxusW+7V2 znvbb98UtHG2q6zGK1sL4TtrlViKMxINtZiLihMBue88dKgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRmVeSWpSXmKPExsVy+t9jQd1nNb9CDdb9UrJouBpisfzCEiaL /+tvs1hc3jWHzaL7+g42ix0LqxzYPHbOusvucfjHD2aPvi2rGD0+b5ILYIlqYLTJSE1MSS1S SM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAdqtpFCWmFMKFApILC5W 0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcxYtOIyU0GHeMW5R/+ZGhh/8HcxcnJICJhI3H+z lR3CFpO4cG89WxcjF4eQwCxGidlf7zFDOA8YJTpPXWcFqeIV0JI4PG86E4jNIqAq8W7qHDCb TUBb4u70LUA2B4eoQITE4wtCEOWCEj8m32MBCYsIGErM+i4OMpJZYAGjxPeT+8DKhQXcJa7v MYBYdZZRYtPZpWwgvZwCwRI35jUzgtjMAmYSj1rWMUPY8hKb17xlnsAIdCXCillIymYhKVvA yLyKUSK1ILmgOCk91ygvtVyvODG3uDQvXS85P3cTIziGn0nvYDy8y/0QowAHoxIPr4LLr1Ah 1sSy4srcQ4wSHMxKIrws2UAh3pTEyqrUovz4otKc1OJDjKbAMJjILCWanA9ML3kl8YbGJuam xqaWJhYmZpZK4ryyK5+FCgmkJ5akZqemFqQWwfQxcXBKNTBmLNsv7HheX/74S9HGshi/pN2z ml+Y358ZNVFXY/GvXXJPhPsfVZpMMCyYaJB9we+M1JKU05ycgefefWDble6uJ8zb+OKFmLHI HLN1dcm/TndqsC8XL3lQ2HCiZ2piBKvEhMzW5r2dj14lmO8TPWhy3PhhidoauQROtkMfzqiJ ce/5nVLO6KHEUpyRaKjFXFScCAB08Ik99wIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Amit On 08/26/2015 11:55 AM, amit daniel kachhap wrote: > On Fri, Aug 21, 2015 at 2:58 PM, Alim Akhtar wrote: >> From: Seungwon Jeon >> >> Behavior of the "powwer mode change" contains vendor specific > s/powwer/power ok >> operation known as pwr_change_notify. This change adds return >> for pwr_change_notify to find success or failure. >> >> Signed-off-by: Seungwon Jeon >> Signed-off-by: Alim Akhtar >> --- >> drivers/scsi/ufs/ufshcd.c | 22 +++++++++++++++------- >> 1 file changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index 8982da9..142a927 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi/ufs/ufshcd.c >> @@ -2579,14 +2579,18 @@ static int ufshcd_change_power_mode(struct ufs_hba *hba, >> dev_err(hba->dev, >> "%s: power mode change failed %d\n", __func__, ret); >> } else { >> - if (hba->vops && hba->vops->pwr_change_notify) >> - hba->vops->pwr_change_notify(hba, >> - POST_CHANGE, NULL, pwr_mode); >> + if (hba->vops && hba->vops->pwr_change_notify) { >> + ret = hba->vops->pwr_change_notify(hba, >> + POST_CHANGE, NULL, pwr_mode); >> + if (ret) >> + goto out; >> + } >> >> memcpy(&hba->pwr_info, pwr_mode, >> sizeof(struct ufs_pa_layer_attr)); >> } >> >> +out: >> return ret; >> } >> >> @@ -2601,14 +2605,18 @@ int ufshcd_config_pwr_mode(struct ufs_hba *hba, >> struct ufs_pa_layer_attr final_params = { 0 }; >> int ret; >> >> - if (hba->vops && hba->vops->pwr_change_notify) >> - hba->vops->pwr_change_notify(hba, >> - PRE_CHANGE, desired_pwr_mode, &final_params); >> - else >> + if (hba->vops && hba->vops->pwr_change_notify) { >> + ret = hba->vops->pwr_change_notify(hba, >> + PRE_CHANGE, desired_pwr_mode, &final_params); >> + if (ret) >> + goto out; >> + } else { >> memcpy(&final_params, desired_pwr_mode, sizeof(final_params)); >> + } >> >> ret = ufshcd_change_power_mode(hba, &final_params); >> >> +out: >> return ret; >> } >> EXPORT_SYMBOL_GPL(ufshcd_config_pwr_mode); >> -- >> 1.7.10.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >