From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754299AbbIQJL7 (ORCPT ); Thu, 17 Sep 2015 05:11:59 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36149 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754722AbbIQJLw (ORCPT ); Thu, 17 Sep 2015 05:11:52 -0400 Message-ID: <55FA83D5.9010504@linaro.org> Date: Thu, 17 Sep 2015 11:11:49 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Caesar Wang , Heiko Stuebner , Catalin Marinas , Will Deacon CC: linux-kernel@vger.kernel.org, Thomas Gleixner , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible References: <1442476272-31723-1-git-send-email-wxt@rock-chips.com> <1442476272-31723-2-git-send-email-wxt@rock-chips.com> In-Reply-To: <1442476272-31723-2-git-send-email-wxt@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Caesar, On 09/17/2015 09:51 AM, Caesar Wang wrote: > Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform, > There are some failure with build up on timer driver for rockchip. > > logs: > ... > drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ' undeclared I think the NO_IRQ definition is missing for ARM64. > /tmp/ccdAnNy5.s:47: Error: missing immediate expression at operand 1 -- > `dsb` > ... > > The problem was different semantics of dsb on btw arm32 and arm64, > Here we can convert the dsb with insteading of dsb(sy). What happens to ARM32 then ? > Meanwhile, I change a bit to make the code more readability for driver > when I check the code style. > > Signed-off-by: Caesar Wang -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog