From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751849AbbIQKjU (ORCPT ); Thu, 17 Sep 2015 06:39:20 -0400 Received: from foss.arm.com ([217.140.101.70]:40681 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbbIQKjS (ORCPT ); Thu, 17 Sep 2015 06:39:18 -0400 Subject: Re: [PATCH] modify pl011 driver to let it work as wakeup source To: Zhaoyang Huang , "linux-pm@vger.kernel.org" , "linux@arm.linux.org.uk" , "gregkh@linuxfoundation.org" , "jslaby@suse.com" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1442478716-7377-1-git-send-email-zhaoyang.huang@linaro.org> Cc: Sudeep Holla , "amit.kucheria@linaro.org" , "daniel.lezcano@linaro.org" From: Sudeep Holla Message-ID: <55FA9852.9030704@arm.com> Date: Thu, 17 Sep 2015 11:39:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442478716-7377-1-git-send-email-zhaoyang.huang@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/09/15 09:31, Zhaoyang Huang wrote: > the commit use the latest dev_pm_set_wake_irq API instead > of the enable_irq_wake and IRQF_NO_SUSPEND to configure the > ttyAMA device to work as the wakeup source > As I mentioned earlier[1], if this a based on Juno platform, then it gets NACK. Please add this feature when it's needed on a real platform on which hardware supports UART/PL011 as a wake source. Do you have any such platform to test ? On Juno, it can't be used as wakeup source. Regards, Sudeep [1] https://www.marc.info/?l=linux-pm&m=144239396227080&w=2