From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF43A279907 for ; Thu, 16 Jul 2026 06:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784184177; cv=none; b=Ni6++GYsxr6RIkCKWSBS+BaLhYD1LYTZWWbPtj+waFcI6jBNAUkNX+BUFPn+YI+dwnkNVFL5QPLfz5U3EC0siamk4ztivD+6PGRCN3zTJ/83F9C5SK4P0CB3OAf5dyjjBrwMqlLONJeRNN8jXvlvGeVpVrDWPS+ZOr413f3SjMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784184177; c=relaxed/simple; bh=bxP+Iob0uYXZx1jF+aVrA8SMBuKJ+8H47+0ZSsb5mBg=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=MVC3mmPqyUDMPBcuvjKR16uO/Gt5dKkXUXk0QgtVUNqXyLdlzCtw8e2Lygdeya3XbJ1FJCFc43FPw6oEI7Na/9M6N6ivPl0gGuDJq9beek6rpvydRxN2Lb362l4bWj3tTMQNpBHLjjsh8zyU+jz5IF8LSi9dqlc+1VderiNCWgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dQhH76x1; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dQhH76x1" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso3390159f8f.1 for ; Wed, 15 Jul 2026 23:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784184174; x=1784788974; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:from:to:cc :subject:date:message-id:reply-to:content-type; bh=bxP+Iob0uYXZx1jF+aVrA8SMBuKJ+8H47+0ZSsb5mBg=; b=dQhH76x1GdkpGTgqIrHGy4i4mj8SgO5hRt3kCUa0VhcPN9Mvg972W4qGfidk30cFUg zqToWIek55URk5P+rHJFVXjenBxeiuO7ZTDxc+bGpQ8fqufInUOQAwcTsdUy3vGyhp9i g09EE4+hVtwwFjuSNShDvnwXKbNyuJo5CScpv76Tpe8umDGsVU2knWXBfFXWf1WVbGB6 zpv/8A3vRiTYMJa2Bl3KJgAJPjhBIKeK1GqFXlOOm3FOnTmcpt1mV5cnk9s2mn7FNfxW KAZk5b3asFkcwqxEFZQj8t/EIJbTVH0wtDFj2qXVk+4R6h2w/FoZ+WvpjAiGodZM81VE YM6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784184174; x=1784788974; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bxP+Iob0uYXZx1jF+aVrA8SMBuKJ+8H47+0ZSsb5mBg=; b=aXJ9bTMgOhRqioGpsmkr2IMRZnbMNvhZfDPYGWSr0qSBi9K/eoguo14hSWabJX0zmL yQb9+Gg+d4rVsesMatlXJMrU8n85zaBEswIrb7P0w9wf2K/kX2R0xz69JEdeEaS0WPVA //MrRVWuYuc5bdaqDLvs3ihys3+DuchN92h4XPQEb7qMYVMdCqE/UYmVzUhG0vNfdcGF 6c1qQkJvdibMiBMWBLJU6O8HO4RwKP7Ctj0dA1VKHbGNsLKI3/b+qjZtB1IM8W5tmbzf 4oWmeuo4l1egYtgyourwiE0nGFyNeRg2rJo7IDCh+PDLBOcWVO8v/x+LfKgDKCpzhEAa q5CQ== X-Forwarded-Encrypted: i=1; AHgh+RoCwOWWzfMm+/z/K1Wnc71uW2f47sC/1saeWVRiZ3dDFVop2+C3uOam5nlDUacI8sSjnToXHZrTGoO6Y9U=@vger.kernel.org X-Gm-Message-State: AOJu0YwiC53qgicKKjqwyrE+WW8oCRZQzViPQcWljE5RjRYpJ1NcjHEl ZK6TpMfY27VkQ4pNLuR3N69H+WdSYW+05pv4VkXNsK5yJFx2QSvNca4y X-Gm-Gg: AfdE7cnhxIuyIGK0iKkSvSRiNCaDLl1XjP9RNf7O4stgzhrW5YrriCBM0KuaBeSoEFr TqztgoKDnsTc/o3t+2nfvGr8g1talxzSEWexlzvt/bF2tQgNnShGztXXWVJ/9/ozawaBBwfZzeq hOkk4Ck+/rphjtC1q5Lhrw5AHzzVITe/5cGGcnWWqkk9es8Av5Nuo4P5GL47NGAUMRYM3hRNhyb 8stMGhgmk0RYtWvu4EdbFB6fVmFnNy30VTQrpB5jtWMyIFnHqNVZU/IqwdcmDLIcQU4U0rSm/Oj WftpvFudqHrOuMxAeviMIE6DQClGh5FovGe94vNe3nkDA1fv0m2fpp0P/DDE/UPEgLROzJxiV2h t+l2BuiHkh6MDZLKAE7VZt4BdomxQzRKyKjFW7dkQmdi2EZRtfPxZpjdRmzaWP4Bym+RN6/0fcP F8WuqQznDIwzEMebfAR0OqwQ4HzSMhRaoSUpYrOa1n1hH1BCUsUR+nB+ylhq/4UV1OIaBE4oFy X-Received: by 2002:a05:6000:288a:b0:470:3edf:e2a7 with SMTP id ffacd0b85a97d-47f4fce455dmr6663447f8f.37.1784184174035; Wed, 15 Jul 2026 23:42:54 -0700 (PDT) Received: from smtpclient.apple ([151.251.247.26]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f4635c86csm22075375f8f.16.2026.07.15.23.42.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2026 23:42:53 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.8\)) Subject: Re: [PATCH v3] wifi: mwifiex: replace one-element arrays with flexible array members From: George Valkov In-Reply-To: Date: Thu, 16 Jul 2026 09:42:42 +0300 Cc: briannorris@chromium.org, kees@kernel.org, bhelgaas@google.com, s.kerkmann@pengutronix.de, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <55FE8005-625D-43FF-BA57-E2E94C6EF694@gmail.com> References: <202607150932.F2A0836@keescook> <20260716001728.57799-1-gvalkov@gmail.com> <20260716061638.GB9973@francesco-nb> To: Dan Carpenter , Francesco Dolcini , johannes.berg@intel.com X-Mailer: Apple Mail (2.3826.700.81.1.8) > On 16 Jul 2026, at 9:27=E2=80=AFAM, Dan Carpenter = wrote: >=20 > On Thu, Jul 16, 2026 at 08:16:38AM +0200, Francesco Dolcini wrote: >> On Thu, Jul 16, 2026 at 03:17:28AM +0300, Georgi Valkov wrote: >>> Replace deprecated one-element arrays with flexible array members. >>> CONFIG_FORTIFY_SOURCE reports the following warning when >>> one-element arrays are used as variable-length buffers: >>>=20 >>> sta_cmd.c:1033 mwifiex_sta_prepare_cmd >>> memcpy: detected field-spanning write (size 84) of single field >>> "domain->triplet" at .../marvell/mwifiex/sta_cmd.c:1033 (size 3) >>>=20 >>> Convert affected structs to use flexible array members. >>> - Preserve existing wire layouts. >>> - Use DECLARE_FLEX_ARRAY() for structs inside affected unions. >>>=20 >>> Tested-on: WRT3200ACM, OpenWrt >>> Signed-off-by: Georgi Valkov >>=20 >> Cc: stable@vger.kernel.org # 6.12+ >> Reviewed-by: Francesco Dolcini >=20 > Are we CCing stable for this sort of thing? Yes, please add stable if possible. I am new to this process and still learning the rules. > How many FORTIFY_SOURCE > warnings are still remaining? So far I have observed only the warning on sta_cmd.c:1033. I made the rest of the changes as preventative measures, because they are flexible arrays used in the same way. Georgi Valkov=