From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: "Cormier, Jonathan" <jcormier@criticallink.com>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: <alsa-devel@alsa-project.org>, Bob Duke <bduke@criticallink.com>,
Mark Brown <broonie@linaro.org>, <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>, Jyri Sarha <jsarha@ti.com>,
Mike Williamson <michael.williamson@criticallink.com>,
Greg Gluszek <greg.gluszek@criticallink.com>,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [alsa-devel] [PATCH RFC 1/7] ASoC: tlv320aic26: Add device tree binding
Date: Mon, 21 Sep 2015 11:38:28 +0300 [thread overview]
Message-ID: <55FFC204.9000903@ti.com> (raw)
In-Reply-To: <1442607076-26681-2-git-send-email-jcormier@criticallink.com>
On 09/18/2015 11:11 PM, Cormier, Jonathan wrote:
> diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c
> index 620ab9ea1ef0..91fdd96648bd 100644
> --- a/sound/soc/codecs/tlv320aic26.c
> +++ b/sound/soc/codecs/tlv320aic26.c
> @@ -370,10 +370,20 @@ static int aic26_spi_remove(struct spi_device *spi)
> return 0;
> }
>
> +#if defined(CONFIG_OF)
You don't need the #ifdef here
> +static const struct of_device_id tlv320aic26_of_match[] = {
> + { .compatible = "ti,tlv320aic26", },
> + {},
> +};
> +#endif
> +
> static struct spi_driver aic26_spi = {
> .driver = {
> .name = "tlv320aic26-codec",
> .owner = THIS_MODULE,
> +#if defined(CONFIG_OF)
neither here.
> + .of_match_table = of_match_ptr(tlv320aic26_of_match),
> +#endif
> },
> .probe = aic26_spi_probe,
> .remove = aic26_spi_remove,
>
--
Péter
next prev parent reply other threads:[~2015-09-21 8:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 20:11 [PATCH RFC 0/7] ASoC: tlv320aic26: Add device tree support and bug fixes Cormier, Jonathan
2015-09-18 20:11 ` [PATCH RFC 1/7] ASoC: tlv320aic26: Add device tree binding Cormier, Jonathan
2015-09-21 8:38 ` Peter Ujfalusi [this message]
2015-09-21 13:01 ` [alsa-devel] " Jon Cormier
2015-09-18 20:11 ` [PATCH RFC 2/7] ASoC: tlv320aic26: Fix module autoload Cormier, Jonathan
2015-09-18 20:11 ` [PATCH RFC 3/7] ASoC: tlv320aic26: Make SND_SOC_TLV320AIC26 user-visible Cormier, Jonathan
2015-09-18 20:11 ` [PATCH RFC 4/7] ASoC: tlv320aic26: Fix regmap by setting reg_defaults and reg_stride Cormier, Jonathan
2015-09-18 20:11 ` [PATCH RFC 5/7] ASoC: tlv320aic26: hw_params was unintentionally clearing AIC26 master mode Cormier, Jonathan
2015-09-18 20:11 ` [PATCH RFC 6/7] ASoC: tlv320aic26: Add support for DSP_B data format Cormier, Jonathan
2015-09-21 6:19 ` Peter Ujfalusi
2015-09-21 13:05 ` Jon Cormier
2015-09-18 20:11 ` [PATCH RFC 7/7] ASoC: tlv320aic26: Change Capture Mute to Capture Switch to match alsa documentation Cormier, Jonathan
2015-09-25 18:30 ` [PATCH V1 0/6] ASoC: tlv320aic26: Add device tree support and bug fixes Cormier, Jonathan
2015-09-25 18:30 ` [PATCH V1 1/6] ASoC: tlv320aic26: Add device tree binding Cormier, Jonathan
2015-09-25 18:30 ` [PATCH V1 2/6] ASoC: tlv320aic26: Fix module autoload Cormier, Jonathan
2015-09-25 18:30 ` [PATCH V1 3/6] ASoC: tlv320aic26: Make SND_SOC_TLV320AIC26 user-visible Cormier, Jonathan
2015-09-25 18:30 ` [PATCH V1 4/6] ASoC: tlv320aic26: Fix regmap by setting reg_defaults and reg_stride Cormier, Jonathan
2015-09-25 18:30 ` [PATCH V1 5/6] ASoC: tlv320aic26: hw_params was unintentionally clearing AIC26 master mode Cormier, Jonathan
2015-09-25 18:30 ` [PATCH V1 6/6] ASoC: tlv320aic26: Change Capture Mute to Capture Switch to match alsa documentation Cormier, Jonathan
2015-09-30 10:43 ` [PATCH V1 0/6] ASoC: tlv320aic26: Add device tree support and bug fixes Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FFC204.9000903@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=bduke@criticallink.com \
--cc=broonie@linaro.org \
--cc=greg.gluszek@criticallink.com \
--cc=jcormier@criticallink.com \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.williamson@criticallink.com \
--cc=misael.lopez@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome