From: Justin Chen <justin.chen@broadcom.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
florian.fainelli@broadcom.com,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: phy: Only resume phy if it is suspended
Date: Tue, 5 Dec 2023 16:10:38 -0800 [thread overview]
Message-ID: <55a08719-cd18-4a01-9a2a-0115065c06a6@broadcom.com> (raw)
In-Reply-To: <7e3208aa-3adf-47ec-9e95-3c88a121e8a3@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
On 12/5/23 4:03 PM, Andrew Lunn wrote:
> On Tue, Dec 05, 2023 at 03:42:29PM -0800, Justin Chen wrote:
>> Resuming the phy can take quite a bit of time. Lets only resume the
>> phy if it is suspended.
>
> Humm...
>
> https://lore.kernel.org/netdev/6d45f4da-c45e-4d35-869f-85dd4ec37b31@lunn.ch/T/
>
> If Broadcom PHYs are slow to resume, maybe you should solve this in
> the broadcom resume handler, read the status from the hardware and
> only do the resume if the hardware is suspended.
>
> Andrew
Right... Guess this won't work. It is odd that during resume we call
__phy_resume twice. Once from phy_resume() and another at phy_start().
Let me rethink this. Thanks for the feedback.
Justin
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]
next prev parent reply other threads:[~2023-12-06 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 23:42 Justin Chen
2023-12-06 0:03 ` Andrew Lunn
2023-12-06 0:10 ` Justin Chen [this message]
2023-12-06 0:12 ` Florian Fainelli
2023-12-07 17:56 ` Florian Fainelli
2023-12-07 18:50 ` Russell King (Oracle)
2023-12-08 17:36 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55a08719-cd18-4a01-9a2a-0115065c06a6@broadcom.com \
--to=justin.chen@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®