From: Deepak Mishra <linux.dkm@gmail.com>
To: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
linux.dkm@gmail.com, straube.linux@gmail.com
Subject: [PATCH v5 2/6] staging: rtl8712: Removed redundant code from function oid_rt_pro_write_register_hdl
Date: Sun, 9 Jun 2019 18:01:41 +0530 [thread overview]
Message-ID: <55a2a17ea5f1bc4be7c16e6996ad890aef8f519a.1560081971.git.linux.dkm@gmail.com> (raw)
In-Reply-To: <cover.1560081971.git.linux.dkm@gmail.com>
In function oid_rt_pro_write_register_hdl, Adapter->ImrContent is
assigned with RegRWStruct->value but Adapter->ImrContent is never used
anywhere else. So those lines has no impact and are removed removed.
As that was the only place where ImrContent was used, so the member
variable is removed from the structure _adapter
Signed-off-by: Deepak Mishra <linux.dkm@gmail.com>
---
drivers/staging/rtl8712/drv_types.h | 1 -
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 5 -----
2 files changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
index d4262a68dd4d..9fbd19f03ca9 100644
--- a/drivers/staging/rtl8712/drv_types.h
+++ b/drivers/staging/rtl8712/drv_types.h
@@ -149,7 +149,6 @@ struct _adapter {
bool surprise_removed;
bool suspended;
u32 IsrContent;
- u32 ImrContent;
u8 eeprom_address_size;
u8 hw_init_completed;
struct task_struct *cmdThread;
diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
index 588346da1412..add6c18195d6 100644
--- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
+++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
@@ -661,11 +661,6 @@ uint oid_rt_pro_write_register_hdl(struct oid_par_priv *poid_par_priv)
status = RNDIS_STATUS_NOT_ACCEPTED;
break;
}
-
- if ((status == RNDIS_STATUS_SUCCESS) &&
- (RegRWStruct->offset == HIMR) &&
- (RegRWStruct->width == 4))
- Adapter->ImrContent = RegRWStruct->value;
}
return status;
}
--
2.19.1
next prev parent reply other threads:[~2019-06-09 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 12:31 [PATCH v5 0/6] staging: rtl8712: cleanup struct _adapter Deepak Mishra
2019-06-09 12:31 ` [PATCH v5 1/6] staging: rtl8712: Fixed CamelCase for EepromAddressSize Deepak Mishra
2019-06-09 12:31 ` Deepak Mishra [this message]
2019-06-09 12:31 ` [PATCH v5 3/6] staging: rtl8712: Fixed CamelCase cmdThread rename to cmd_thread Deepak Mishra
2019-06-09 12:31 ` [PATCH v5 4/6] staging: rtl8712: removed unused variables from struct _adapter Deepak Mishra
2019-06-09 12:31 ` [PATCH v5 5/6] staging: rtl8712: Renamed CamelCase wkFilterRxFF0 to wk_filter_rx_ff0 Deepak Mishra
2019-06-10 15:58 ` Greg KH
2019-06-09 12:31 ` [PATCH v5 6/6] staging: rtl8712: Renamed CamelCase lockRxFF0Filter to lock_rx_ff0_filter Deepak Mishra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55a2a17ea5f1bc4be7c16e6996ad890aef8f519a.1560081971.git.linux.dkm@gmail.com \
--to=linux.dkm@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome