From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE47B1A2642 for ; Fri, 7 Mar 2025 08:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741337206; cv=none; b=lxNFNi2Lhv4HerYlIWwfUTLrAgdYJAMiqKiOdA4eSvCriUqQMfBwjyOlJVuqD/kzNtJbUL/09QjbJLYoaPumA0EC1r8fanRGxJuXQ1LPvi+Eb3Fh6dEyhZ9bGY/VIEKaV+8ikoiAAnrZJGqbf3ebRyRY6meUrpb2kLoab0wAvsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741337206; c=relaxed/simple; bh=fKk5IlJrtgZGxwBN1L8aq8vNMpWqWsbH9W2eqn1VRNw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cCcS6Bz64nShkoQlCopfNi2j5oloqm7QA1n/gx4bfM1cOWMkmRGj1MR2bipLpJSME7wzi5pKOg+YRTDlpXpviILDTZBoF2aCe9H42kDmw5AvWWhJgrBt5xoxqJYOD3Bgh1AdvGdAc55XCL8Sg8OVx5c2fu1txuhnqwKrqQ7xeDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fWpQmkc6; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fWpQmkc6" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43bc4b16135so9235595e9.1 for ; Fri, 07 Mar 2025 00:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741337203; x=1741942003; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CeCzp50wQFSHXwUSgk1GK0yw7rurMqQ1v0KAQL33c9Q=; b=fWpQmkc6VCH17moFp2gA8PhLXV55aP/S+YrvQ7D52wJNnizEk+fToz5a/rCsFaQF0u 1PrRY0i+M63N6FzMgnWeTAmg7fym2asbumBBsDr4umxxbscW7OD80GWudJhrPQjs6PCG sZLwMvU2bvdviIPYaiKODML6p8l5Ce268T0sqE/nnOVkN422RLKphVEG+TNVSOnct9ha K3gx8KfTcsWr8DlZuWxsB8MLvVVkHumdef9PbW1yv0WO2x9stbemAJWLDq91xadw/wI2 X2GhLUZBZ+m3D934r5wn4GMuUrFpdmAL+rDVvGKkhcMy0mYI1awzfORQIp7sqHMjufC3 Gubg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741337203; x=1741942003; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CeCzp50wQFSHXwUSgk1GK0yw7rurMqQ1v0KAQL33c9Q=; b=jk2myAsAMttrTUq0PhcM34gpdyYgbo1Ay575Sx1LJoyYY1AR8FJJNlIvQU+UH1EvKt 66S6J3+ieef7Hi3KDygXcDO/pbEzWMTcbkSj+TVxrO8reqHreJKyuh0QJwycyX6FIfab Rj4YRsY+OYWe4e28weRe0tvx3MVT8nP+4qFIs32n57U09gfJO6ipSF6habJnKLshiNXG jnZhifClFerAR9eY00atBPPDZheQ4tWu93S91xgUGH/tkSvSdzyW981g+xdXvOD9phfk fzWsdr5dU5BbTX/hCUsV8559WJ7tegb4te04PKf/YWAcAkBv8d+lTDJFZLIa4rsSBr8j meOw== X-Forwarded-Encrypted: i=1; AJvYcCWAkhs7scvyDIlKXVldfUHim2FNmC5T8VFDiGgA1nPTOVHunM1zRvm0DQgpqTQR+vRrscHM+C/1S0roqSE=@vger.kernel.org X-Gm-Message-State: AOJu0YxlL/7r+Yq6QFHO/d9jmoCjgq+4aFAKG6NZ2cgWdeR1rJjWsSPA w4IzJnmYIAfZWtul0t0xkSl+pwCHk2xcJk6kQ0X5fJ4/jniHG2tSOJ6aCwmXUQs= X-Gm-Gg: ASbGncuzokRPHue/JTWrAJHV4unKOtxTje/mLrkJb0e11+M/VkQKuNdp5zP5V/UTl5/ 5XPlnnPBnyc/g8hwhei7FJGmxQVsL03jCYqGkWvFd6PjxChrqCtztlPgddXPdURg50U7blLtXEN rq+Ui/pxjec2M0epNKnfNAJHsDMpyCdL9WxgyHF3fGs1677qkHy5xoeWrdFgKr/4tCpw/++lWP1 LURRipmxkNUt4+GzrK8Ynva7su26UIn25qPrUcSN0viQzkkCWXnQVn3QwVkLtcB4afYKWxniXuT Lr7LuNW5wYOgQAVmx1VjalbwrTmOu3SolpfkaBDNTOPEaEhgmg== X-Google-Smtp-Source: AGHT+IHm1ROMeb88xzMcstE8qmldjWdwE8YGxzBhlEQ+q3xNIiZZGzfSSGSPfht50sw4bsGjMidAfA== X-Received: by 2002:a05:600c:35d1:b0:43b:da2b:762d with SMTP id 5b1f17b1804b1-43c601d90c8mr17653315e9.7.1741337202942; Fri, 07 Mar 2025 00:46:42 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43bd6530f26sm71167885e9.4.2025.03.07.00.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 00:46:42 -0800 (PST) Date: Fri, 7 Mar 2025 11:46:34 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Helgaas , Lorenzo Pieralisi , Arnd Bergmann , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] PCI: remove stray put_device() in pci_register_host_bridge() Message-ID: <55b24870-89fb-4c91-b85d-744e35db53c2@stanley.mountain> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: This put_device() was accidentally left over from when we changed the code from using device_register() to calling device_add(). Delete it. Fixes: 9885440b16b8 ("PCI: Fix pci_host_bridge struct device release/free handling") Signed-off-by: Dan Carpenter --- drivers/pci/probe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 9ce83a1d6e31..819d23ce3565 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -999,10 +999,9 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge) /* Temporarily move resources off the list */ list_splice_init(&bridge->windows, &resources); err = device_add(&bridge->dev); - if (err) { - put_device(&bridge->dev); + if (err) goto free; - } + bus->bridge = get_device(&bridge->dev); device_enable_async_suspend(bus->bridge); pci_set_bus_of_node(bus); -- 2.47.2