From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0CF3C2D0A3 for ; Thu, 12 Nov 2020 11:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59E6F221FE for ; Thu, 12 Nov 2020 11:24:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W+eu3SDU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727969AbgKLLYM (ORCPT ); Thu, 12 Nov 2020 06:24:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbgKLLYJ (ORCPT ); Thu, 12 Nov 2020 06:24:09 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC766C0613D1 for ; Thu, 12 Nov 2020 03:24:08 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id b8so5627686wrn.0 for ; Thu, 12 Nov 2020 03:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=szqL77OyEVf5vlwPlO5u0pCoBC9WdDfxlvV/jS14f7E=; b=W+eu3SDUj96qApW3fPXVb+xDPNnyinb5iqfjnyWgB2qExiVq0mQwKnClSWWjqkt8OZ fJkNHuW70oPJ/doSMrRfRizxIy6jPW2wSlMD8toIvwPk5bh3fOAjgdTBYKG/Aus9N9t3 1bJoWq2anjY3zJZ1pi/FzmllzANSkW2psCgx/vfhv4AXT2YLr/yavichSFSXUCCwNrvZ BHE5035iiBFf6o7siVYZHXjfPiHIdnlGvxplVVriBuEdYHoBIAItWvqRUCeFfG2E6LEa boMBxnUabqFVx09Y8reV5qhqsNMi1rHBANv77VZJ8stUSMd8Y4OfMQ2Vnr292kt8GE6m oE2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=szqL77OyEVf5vlwPlO5u0pCoBC9WdDfxlvV/jS14f7E=; b=RCqfmYJDLz0pCQLEJ1X3/EJWdf0FYL1JqVsRF45jTdaWxQLo+5NHXJq4eXIrN5AFMM Xa6YVuYcSb4+LEQG/LLbE4QOhls5OGShAQJJpK5HjXJ1VmTS4LtsoBbBDbRBX2Qa4CWz d6m762DmN2Wng7hmrFr3tYkye5WYTNKWpa6aBJ2elPKuiNBEXnAHxiAiHEYXGZ8LAAON fMHVsrqM0s2v+UGTvsxzmO7gQZ1sk1BuKk2vfIV6HZ7SMcVD5LQkWIBKXPypqZmmUgtP gKEShwWvBiBbohmcyM1/00wm5b2MEx7fKRMlPgLN/xhXriawvBndYV7u0NhjOqk8r2kP 12HQ== X-Gm-Message-State: AOAM531RMT3N8ZzTknR89nHCVRRiG7m7Ujqx8O2TLZhwMBKQcQyfF45i 6Y6UgiC4KAztLID9kUmfNcLNJQ== X-Google-Smtp-Source: ABdhPJxH7/ZKgWoWnVYh+D4j8m7LwUtdScXYKtOerDowIYHrkBFRK+sNKPZHBUWJnvIbUw7Xl+MMVw== X-Received: by 2002:a5d:444c:: with SMTP id x12mr23015463wrr.6.1605180247340; Thu, 12 Nov 2020 03:24:07 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:6971:b700:3764:fa96? ([2a01:e34:ed2f:f020:6971:b700:3764:fa96]) by smtp.googlemail.com with ESMTPSA id q7sm6837706wrg.95.2020.11.12.03.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 03:24:06 -0800 (PST) Subject: Re: [PATCH v2] thermal/drivers/cpufreq_cooling: Update cpufreq_state only if state has changed To: zhuguangqing83@gmail.com, viresh.kumar@linaro.org, amit.kachhap@gmail.com, javi.merino@kernel.org, rui.zhang@intel.com, amitk@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Zhuguangqing , "v5 . 4+" References: <20201106092243.15574-1-zhuguangqing83@gmail.com> From: Daniel Lezcano Message-ID: <55b484fb-1532-e130-3b05-5a7f5e18a536@linaro.org> Date: Thu, 12 Nov 2020 12:24:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201106092243.15574-1-zhuguangqing83@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2020 10:22, zhuguangqing83@gmail.com wrote: > From: Zhuguangqing > > If state has not changed successfully and we updated cpufreq_state, > next time when the new state is equal to cpufreq_state (not changed > successfully last time), we will return directly and miss a > freq_qos_update_request() that should have been. > > Fixes: 5130802ddbb1 ("thermal: cpu_cooling: Switch to QoS requests for freq limits") > Cc: v5.4+ # v5.4+ > Signed-off-by: Zhuguangqing > Acked-by: Viresh Kumar > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog