From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5F1C342C88 for ; Fri, 20 Feb 2026 12:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771589138; cv=none; b=ttvxooU+X4y6iU3SXII/5/MXwaaHIfWj2j5il6B4cNPBK3Uko3DyAPLrLs+RO+3RbepN7Y2fZq0vYjpVyAkIMiT74K17jyfooUA/1DHS/gSlkKpDG/saLfyZxmZJLnNwMIzcDfyns4vaML/jG+s9HfKCtgU/8h0xXZRF4Own8oI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771589138; c=relaxed/simple; bh=5589XGveaJrFKM4G0yJEEpKgPGLdvmNfSulvySaX48E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pm1S+NSqmi59THjaq45oW5uH6U0/fh5uSdpb0JUhZKnlnpyfoGWCYvcDhBzDYx/PRIOMXny9fVJLgNQ0LMHLyK+w7Z/JcH4pKo/WSwSaQL0DNSpyU1Yiq+ycQPgvlzRFxIhtWMBpNv8pT2rGRVJk3eQzC5aCoLe1oJ/DI2sFmxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iJfMgScC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h2YacQR4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iJfMgScC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h2YacQR4" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K5Rm7C2506130 for ; Fri, 20 Feb 2026 12:05:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4AnohYpFd1eVw3fRCn/zigCbPOyIedqoq/xhotPnpRo=; b=iJfMgScC9lLge0T1 Ys7GRai8CsZdJ61P77O48Q7QYtxDCjGNfCSz/3KSWXQAVASzFH2EkHo4XBhOo57g gt0z1xriQZc+z82YiH1GhuzlNxXFslZfnh0+BjDIPYxY3OqFjUjG/z3Os5QG2lsL SZ2LXbUg/ilzbuoDhqTSPU24NVPsxXT/rrx7F6suJXbOSIUXKkqugzSlbIWSDLQh vV1dMjr4MuJ4xdhETVGCZu0qJZrFluEPeg7c4Qi8myL8e2Da4H4aLK7+pbjaBxDB tlBbrdBpOK0Q/5oqDmBZzsXWsKUUt6+dWic99FbDPqf6lQgJssaYexhUqXimCYcH A6n8tw== Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cee2s9e65-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Feb 2026 12:05:35 +0000 (GMT) Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-6777b1ac383so30787860eaf.0 for ; Fri, 20 Feb 2026 04:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771589135; x=1772193935; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4AnohYpFd1eVw3fRCn/zigCbPOyIedqoq/xhotPnpRo=; b=h2YacQR4F/Qc6WaJOzkLJ/26uQUa1KklKuXJdFgF59fRBp4mExL8S/esryo3tFmeUc hDcwSK+G6RINO9q6NexEiYY9W5g3al4mrQk/i6cPCo7wtdtkb//kL6jERhuZjzFGi1qN BQvRPFmhT1/pZQniCJUXMR5YYKK2ULxZ9dEYvRZEoybHswiWmT7BEjvaPxaFtjl+UXL1 7kIgmpYjihJtewaEUfZpBNfU4T8WVCmlUZCwLwUbH0XvUkUblO6VBOC9TGfhMmVU6JRN QbszHPHElu/HKk4IIMU0gP9VfTqDLro+hz67WUFX2pNPWLFIblCaHCtK5whv8CV7j+QO y63w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771589135; x=1772193935; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4AnohYpFd1eVw3fRCn/zigCbPOyIedqoq/xhotPnpRo=; b=ExVaEYQxaz65mhZM5mNeZjURVAcqPuZ4zZINIIMyH6jpNr7UTYDZEZgVkopM0XeYht ectsgybVc0PJiOIlWyjYjJTiX4wmOcnxp0tdyMcGh+O4X/uIKaR1eDftd2JNOZdevx6O nD+VDiyncl5PAPjgHKCed2nusvHta2JHqgh5Cw58UQ3JFX/Uz8NHQOcDAODQpEzkB2Yg ti7xRoyXxXJ6IgHxxuXtjMlpd1l7ivkcbOelFXJjOEustLtZgq99E63atKUfPJ556tBI qJR0f641z6b6AbgXilkD5Ctji+tdfGH3yACBMHOSL5BXYwc0iO86UP+Bp3VLFr/g1ORi Ybeg== X-Forwarded-Encrypted: i=1; AJvYcCXfAugiF4AWSHZC51qgoMhDhNULNPuhhfINgUBGYPNsllX0BRDBUB6HaMAKNBufhTOP2cOVOvAKqXqBA5o=@vger.kernel.org X-Gm-Message-State: AOJu0Yx25Gh2/8J/uQGrRYM3//mmeZjFvBbUDHwwhdxzkFsfg733N2xq W0g+/CUTyIqBzM1raoqiq5Gs6nqp/quMZB6mmOMD8uhBlggolD4DsmVxUWDoST0GcGspqTdVMVM 8vTLQUG0wz6KM7dIhqzP9gDRb4PQZ4wMajBa+uXLFfUW2sFa3xLRDeY2mHbiE6HL0Aful8fq7+5 0= X-Gm-Gg: AZuq6aKsXi/RmjSBBv07/+B50LMWN7mVNMcP2Li32Sp/kBKgWgG7vIPMBnuwm8sjZmw 0qLDa1cDY0Ut8Nf4Um0TeuwAoNikCqUMxpHXalEm3kCkYAmta5EUXpah/vlCTPgrEfL53aoh1RJ LsE0n/1L09J6ZBoUWltX80RJIXJHZq2BwEU2Nby+DuASEmNuFd9oihZnfC6k1wocammbF4I52EP DegKZXWyD33agUFL+OpLOO80y1HhQ6Oc1B1tQOV4Pz9m07D283unpAuzTrW7tqGSveP26I3BGEj a8R5/5bv6ZU39o8XWgLzw+q4clTJFqJzaliOgHuC4d8IgakckNG7lK9eTuLaJOr7kg93xIiB3zx 7Q9FP3iWtTD8HhgG3KQ62joJohk4SYJwKi0LcN6fXqsLnLZ4oCHU= X-Received: by 2002:a05:6820:129:b0:679:88ee:e3f8 with SMTP id 006d021491bc7-67988eee8d2mr7916336eaf.68.1771589134950; Fri, 20 Feb 2026 04:05:34 -0800 (PST) X-Received: by 2002:a05:6820:129:b0:679:88ee:e3f8 with SMTP id 006d021491bc7-67988eee8d2mr7916308eaf.68.1771589134515; Fri, 20 Feb 2026 04:05:34 -0800 (PST) Received: from [192.168.29.235] ([49.37.133.168]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6799801b2cfsm8075610eaf.15.2026.02.20.04.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Feb 2026 04:05:34 -0800 (PST) Message-ID: <55b6051f-dee6-4f05-96ac-e24752030d4c@oss.qualcomm.com> Date: Fri, 20 Feb 2026 17:35:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072 To: Krzysztof Kozlowski , Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Balakrishna Godavarthi , Rocky Liao Cc: quic_mohamull@quicinc.com, quic_hbandi@quicinc.com, janaki.thota@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260218114955.3970974-1-vivek.sahu@oss.qualcomm.com> <20260218114955.3970974-2-vivek.sahu@oss.qualcomm.com> Content-Language: en-US From: Vivek Sahu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: UsdI_h7579PD0lU80mL6C3Osa3sWGMTw X-Proofpoint-GUID: UsdI_h7579PD0lU80mL6C3Osa3sWGMTw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDEwNSBTYWx0ZWRfX+lX+Za3wbd1k Qj7PAyxiEgZbn7IkIo9+ctZnlC983bkg7lzdCoMXkZqs+b8IhQZuNu4CYQo3K1uRwww6pnEVhId XgvE2yDrZiHCTJ0JFngWslh4sFnfImMMWtDML68fsfMBF9ev0GhtLtPciBFiQL/wlgZEycRayGJ YXoSa9J4j8LgHRxY79/pkw3kwo3S6Y3yX2ZMAFZEfqmbFY/GdmMc9v7RTyaiTKyj8D4Lx0hhgWu ORroF6gOU4vRAhOWiey6t0Fu9FbeObguaal11pTE63ILtaDCg8KMLxYB2dGQpCLVuDL86FXVEoF AgTxyY8KyvSJQRon33xpPp69azHWH0scDHMh+23LZFFIJkj5QqCt5PGkQwIZDY9JFFA5xWGEJe/ 9C1zcRJdxB2KH9rnbR4II4tnBXCIEgMQ/PJZHwGNDjeK92r4tKl5GbAat52vq4oSIOI/UWU1plx wJYsSvGHCSZpSTQ89YA== X-Authority-Analysis: v=2.4 cv=NajrFmD4 c=1 sm=1 tr=0 ts=69984e0f cx=c_pps a=V4L7fE8DliODT/OoDI2WOg==:117 a=b6EVmk5gcm51ODEEWK3PtA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=P-IC7800AAAA:8 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=2jaMIRPpbWfr_bONL7wA:9 a=QEXdDO2ut3YA:10 a=WZGXeFmKUf7gPmL3hEjn:22 a=d3PnA9EDa4IxuAV0gXij:22 a=sptkURWiP4Gy88Gu7hUp:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200105 On 2/18/2026 5:23 PM, Krzysztof Kozlowski wrote: > On 18/02/2026 12:49, Vivek Sahu wrote: >> QCC2072 is a WiFi/BT connectivity radios which exposes >> UART as an interface for Bluetooth part. >> It requires different configuartions and firmware, so > > different than what? > > Also typo configurations. > >> document it as a new compatible string. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > Different configurations like interrupts GPIOs, firmware binaries, compat string. Commit msg, I'll correct it in next patch of this commit. >> >> Signed-off-by: Vivek Sahu >> --- >> .../net/bluetooth/qcom,qcc2072-bt.yaml | 47 +++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml >> new file mode 100644 >> index 000000000000..7b27c2c651fa >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml >> @@ -0,0 +1,47 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/bluetooth/qcom,qcc2072-bt.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm QCC2072 Bluetooth >> + >> +maintainers: >> + - Balakrishna Godavarthi >> + - Rocky Liao >> + >> +description: >> + Qualcomm QCC2072 is a UART-based Bluetooth controller. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,qcc2072-bt >> + > > Where are clocks? > > Where are supplies? > QCC2072 exposes M.2 UART as an interface for Bluetooth part. It doesn't require clocks and voltage regulators to power it up. >> + enable-gpios: >> + maxItems: 1 >> + description: GPIO specifier for the chip interrupt. > > Interrupt? No, it cannot be interrupt. This can be only enable pin and > then description is redundant. Look at other bindings. > > Looks like matching QCA2066, except missing clocks, or like other QCA > devices with proper supplies. > > I don't believe that Bluetooth device works without power. > It is an interrupt to the HOST. I'll make it more comprehensive in the next patch of this commit. QCC2072 exposes M.2 UART as an interface for Bluetooth part. It doesn't require clocks and voltage regulators to power it up. >> + >> +required: >> + - compatible >> + - enable-gpios >> + >> +allOf: >> + - $ref: bluetooth-controller.yaml# >> + - $ref: qcom,bluetooth-common.yaml >> + - $ref: /schemas/serial/serial-peripheral-props.yaml# >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + serial { >> + bluetooth { >> + compatible = "qcom,qcc2072-bt"; >> + enable-gpios = <&tlmm 19 IRQ_TYPE_EDGE_FALLING>; >> + max-speed = <3200000>; > > No firmware? > Firmware is required, it is just I've not added all the fields in the example. > Best regards, > Krzysztof