From: "Matias Bjørling" <mb@lightnvm.io>
To: "Javier González" <javier@javigon.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH] lightnvm: pblk: add comments wrt locking in recovery path
Date: Fri, 30 Nov 2018 09:36:00 +0100 [thread overview]
Message-ID: <55c31953-4816-c53a-72bf-1d159007378c@lightnvm.io> (raw)
In-Reply-To: <1543404016-14902-1-git-send-email-javier@cnexlabs.com>
On 11/28/2018 12:20 PM, Javier González wrote:
> pblk's recovery path is single threaded and therefore a number of
> assumptions regarding concurrency can be made. To avoid confusion, make
> this explicit with a couple of comments in the code.
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
> drivers/lightnvm/pblk-core.c | 1 +
> drivers/lightnvm/pblk-recovery.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index 44c5dc046912..f1b411e7c7c9 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -1276,6 +1276,7 @@ static int pblk_line_prepare(struct pblk *pblk, struct pblk_line *line)
> return 0;
> }
>
> +/* Line allocations in the recovery path are always single threaded */
> int pblk_line_recov_alloc(struct pblk *pblk, struct pblk_line *line)
> {
> struct pblk_line_mgmt *l_mg = &pblk->l_mg;
> diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c
> index 416d9840544b..4c726506a831 100644
> --- a/drivers/lightnvm/pblk-recovery.c
> +++ b/drivers/lightnvm/pblk-recovery.c
> @@ -13,6 +13,9 @@
> * General Public License for more details.
> *
> * pblk-recovery.c - pblk's recovery path
> + *
> + * The L2P recovery path is single threaded as the L2P table is updated in order
> + * following the line sequence ID.
> */
>
> #include "pblk.h"
>
Picked up for 4.21.
prev parent reply other threads:[~2018-11-30 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 11:20 Javier González
2018-11-30 8:36 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55c31953-4816-c53a-72bf-1d159007378c@lightnvm.io \
--to=mb@lightnvm.io \
--cc=javier@cnexlabs.com \
--cc=javier@javigon.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®