From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70AA62BEFE8 for ; Tue, 25 Aug 2026 03:10:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787627403; cv=none; b=RxhajJxJKdGzGENRjlHvZKAPl7CV0AqiGQeFvp6m/eXFc9xXHm/WQnlRyUVnz8cbZd0VQcsfgcL7Jr8uKX3fQX/2+Z+/hLLX6LSrD6SO4oeUQEc98ys9ZyFTYHuPP5TeQbjmAz3loa3/7+Yp996f2l/n7+vtDr6zcJXhvKIIm9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787627403; c=relaxed/simple; bh=4WCz9YHyg5CCosA45lTrZEfpjiNdQfd7tkaUppLhoJU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=afXI75TblXupr1oGeLQmmN6yjQelwrtbSdYTRypE3UD7b/Reja7cKZX+41WLcaTuO2yGH7HI9suVZRNS9n1w0x66wnppaCm/2CyI/7tIheajhP+KBgM11HG8Ekfeiy8PR3EiVlnc+3muXe6Z1IPpgpZYFg+GPXWPs0NtV0upkgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iOHpof7n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hRQiKldq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iOHpof7n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hRQiKldq" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P2R20m404982 for ; Tue, 25 Aug 2026 03:10:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= auI/TBj3WksZ+3BHU5GHhTelrXI6VszNhGlf081ZjvE=; b=iOHpof7nf1DUJM+j oQqP1eWwm55v/QpHWL0gY1VgJ+tIcutSd3Y/7LDSwTuKgqCCIPDL3RuaggO+J/RF pofPy3RYlpCRgqH1O27CJPBw19eYzS4voQi9vOQpnC7iKB/Y3XgJU8jW+o/IW1U7 eU34+mnZi+o3+HT33jOdyBBIXTgOaT121Yvf3XIjl20OO73FEanoGbNnodjsH1uy GIBBXGe0kE3G55N2L+AWJXk3JXC6GJXUmwz4Wu910NjgEwigK4rjOukeSdQpQNJH GP3QOJhvFbRfNd3Vlo84ZnfGxYpMzSljnX2nn5XT0+pnzM0aXAws9Bm+zjrR97d0 /XVA0w== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8y5jgmfq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 03:10:01 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3954def0191so7486833a91.3 for ; Mon, 24 Aug 2026 20:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787627400; x=1788232200; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=auI/TBj3WksZ+3BHU5GHhTelrXI6VszNhGlf081ZjvE=; b=hRQiKldqLixfSBDw9sj3RYGOtR8WsMd6kWr4H28sST/+iQeeEobH0C7lpIqqi99eyR xxKqp5vj2RDb1bXtmIK6fX5UBKj/DS1SmCEBvkt4329XklXQPQGWDs4uD4a20Qx5z4qy Bx7mXufwwI9pa2bekAp3cglNN9wTLN3PFEYXSAHlqFeCqLDFwlCQTXeFp6Jo58B9hwcg /8F3DX5/exEGheL9sQHHo1dC6vce4LDCZfM5gwwMO7QNtVPsJDD9WyeEQLf4wfVr7ysz qBNCuQOh7c5S6p+9luUlZFWNtLByii1IDJXJo4WiJuUdoQtb9YLy/UsmRdECGP9GAHhP fqyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787627400; x=1788232200; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=auI/TBj3WksZ+3BHU5GHhTelrXI6VszNhGlf081ZjvE=; b=NDnNU/E0BuSoDdTdOwIkXHEcVL/jt8WFnxpZvOttngu7tLK1BQWiqAHxUfzAvdOkqc Ffl1v4wLw/Y5tNgd50Pl0NtXapJfM8nz2HSoo14J4Wag7JoZ5SZYCdH11qImtVvkrHrm jls0unwBL0RecpV1PqjDsJ+d3UiFtdc1fw9318/rqXvApSUFk/yD+7ne1SURfNPsfJyo e6qDdsDs6QtT4dP3UMm7UJvAQVw90py6o5bWxcOv0IqyZiCrDsM29EDspuBkVSj307wN rXVZxgrzn6Ravimjbb2OfkJBtGQuh/Z8lcx/GaFhH26uSNniPzOLLJbBRIV/2E66B9SN Lc7Q== X-Forwarded-Encrypted: i=1; AHgh+RrBrkVwDz1asHAy3/Opy4/uJcAKxZCk3ony/n78a97jJQJ4xCiWyvBD7ggYdEn+tde4eSpB+MPaKn6PTlI=@vger.kernel.org X-Gm-Message-State: AFuF++nopJGuUkKqDI+i7LEP8wJL2XyAVGQZyFmg5KSNo1OFt1ZRcg+b X190zdZaiTPeGEyoqAO/Vdj4gsUzXk47CNRHoE2a9YnVcpB7CaW+e77n+GwvhmJpPqHNRHzxKAv pZcgMuInRfA8A7gJ4i8tw6iwU64f09u7NzVZjOPV4lfm8LMzZHmsNloKa9hifeu2zH3w= X-Gm-Gg: AR+sD11LPGXcmLssYgGMkfalvFGyBfWceAnpWYZsvUwg4e4RJeaJtoF9KZgvpaOagve MQpGtyGud+/Pw1TVum7gcStoNM9zrgOmpk2PgVLwR4ZLA6XOHxCF1X2ZaAjJ+CyBWZ/WE+Zephd 0F5aFFI5R9AB7/7+qvyyI6CmxzjURYiCjn8VQwhgtl2kvwiAmMOD/ab3Hhnzfck3Wb/3V15zC8Y 5F7h2ZLft48mrNO00jQourh/nN33wDL0HMWEVSf2t7C4WBXq1I2VX5AETRO2FqQ9RppeImhiDLc TXn2IP5WVrdcZWoglq5A9m08J/+OiMzezA0QmYOI6RhL3iy4xiAoZE+B+yvQAJuPiVMuAX07urE LFVeVHUM0Kh6B8kJqaAhQNwYBUntERv2IuBVgEFK+V9cMwB0Ia1tPq8F/S1nlap+C X-Received: by 2002:a17:90a:d64e:b0:38e:1497:af5b with SMTP id 98e67ed59e1d1-395c33dd84dmr59024629a91.1.1787627400134; Mon, 24 Aug 2026 20:10:00 -0700 (PDT) X-Received: by 2002:a17:90a:d64e:b0:38e:1497:af5b with SMTP id 98e67ed59e1d1-395c33dd84dmr59024515a91.1.1787627399640; Mon, 24 Aug 2026 20:09:59 -0700 (PDT) Received: from [10.133.33.87] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3964480d4a7sm567481a91.4.2026.08.24.20.09.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 20:09:59 -0700 (PDT) Message-ID: <55c77b0d-6625-4221-a983-8275f3c1d1ae@oss.qualcomm.com> Date: Tue, 25 Aug 2026 11:09:54 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] coresight: tpdm: initialize spinlock before exposing sysfs To: yingchao , Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , Leo Yan , Mao Jinlong , Tao Zhang , jinlong.mao@oss.qualcomm.com, qinyungao@kylinsec.com.cn, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <8693039B65AA093F+20260825020647.2469-1-dengyingchao@kylinsec.com.cn> Content-Language: en-US From: Jie Gan In-Reply-To: <8693039B65AA093F+20260825020647.2469-1-dengyingchao@kylinsec.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=O5QJeh9W c=1 sm=1 tr=0 ts=6a8d0789 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=C4lfG5toAAAA:8 a=EUspDBNiAAAA:8 a=fwXp5HOcM--7f4IBWnQA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=iqleXTDqv_QQetf3OR0u:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDAyMyBTYWx0ZWRfXxgvDdQDgQbVK EEVCtW1jLcT/3FaFDsU5y8HaaBi9Xem5B3mDP8Rp93sTatf5YbAfvgBQZCaXGvY36zr5TPx21xY jF2dKWrOMhKqzSdNEx+5qcJCYp/8az4phwyFihIoShMiMJGkit+opAPyXs100yQgHdOAbXwfomV 5f2M6MSQyUeRJnbU5sHRJ4CbGIYi01S/TxBSAi3ze2PdGjsGjHzUg1oWRTAPWV963VpC8ivWzF+ aEVQB3QlsBcLF9w2zcSm7+A7f7YWqZeF3bAz0TbzIGkDyzvMhYGfc3Sd0GJXsuRlxSpvQ5SGLOi JewzdQ3QU2Pml6S6EojPSeaM9TXysVm3NXAYlAOfAYeCuv2WGVAikYYsRQ+cgK6aYu+z6cTcQLn PQXi4WWMQytAfVWFDU6meybo+zrv4QjGb7Lkwvm1T1BpIMrC2MzyLcT3f4U8l92wfIbe0ARY0d2 QsKMtQbFSM9cYd7jTWg== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDAyMyBTYWx0ZWRfX0gMGyFyh3Inh PeK8mkHw2bf3Q2sB/Yte7eCQnbvJ+2FCMeeJimTMY+rC9GsmRyPVtma87+zxxn2q7cphYgijyRS VtB55fC2CFLfTrLvNE1DDTCquEOzye8= X-Proofpoint-GUID: R9EfJSMxrMBBHTLR3gjeV2h6VcJPCMq2 X-Proofpoint-ORIG-GUID: R9EfJSMxrMBBHTLR3gjeV2h6VcJPCMq2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_01,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250023 On 8/25/2026 10:06 AM, yingchao wrote: > From: Yingchao Deng > > tpdm_probe() initializes drvdata->spinlock after coresight_register(), but > the sysfs attributes registered by coresight_register() use the spinlock. > This exposes a window where a concurrent sysfs write can lock an > uninitialized spinlock. > There is only a very small window during which users have a chance to access the sysfs nodes. But still worthy to fix it. Reviewed-by: Jie Gan > Initialize the spinlock before coresight_register(). > > Fixes: b3c71626a933 ("Coresight: Add coresight TPDM source driver") > Signed-off-by: Yingchao Deng > --- > drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c > index 8464edbba2d4..50d1351772b9 100644 > --- a/drivers/hwtracing/coresight/coresight-tpdm.c > +++ b/drivers/hwtracing/coresight/coresight-tpdm.c > @@ -1457,12 +1457,12 @@ static int tpdm_probe(struct device *dev, struct resource *res) > desc.groups = tpdm_attr_grps; > else > desc.groups = static_tpdm_attr_grps; > + spin_lock_init(&drvdata->spinlock); > + > drvdata->csdev = coresight_register(&desc); > if (IS_ERR(drvdata->csdev)) > return PTR_ERR(drvdata->csdev); > > - spin_lock_init(&drvdata->spinlock); > - > return 0; > } >