From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55DDB23C8AE for ; Fri, 16 Oct 2026 01:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792115035; cv=none; b=q0cYSf9/Fx/dSUuXNkooQzxE9O486ypj9txo0/t4x3x8AKCo9GK3s6XABYuRrr1KLwppgFYx5kx1abzpglfvFhE5mCthNwuSHtmp/jYJve9j9Dd4sqMYbgza8K4hRk/a5bPVNnIbXUamtR1DX80ett4q0I9cgG4nGn71BRqqaJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792115035; c=relaxed/simple; bh=kQkjlsIrQcHp2Nsx17GlvS9gPFBsPnNLRmimpEElKy0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mMhqwxnVv+mr93ErpXJg99IleJGARdQYT3w+iCzj9dXDazq/WQZ+lx7HcjsCK8Lap7UWQK416nXBo4wvp4m6XuHIfs2NRZhRTBAMVywfAC8JPzahKp0c96RnwZQjwAgMEmUoUpmQjOt8cKQKZ1ocMDPrH0XRQTADvn6gNJRGxFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QL6IvYB9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bO9pe9MR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QL6IvYB9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bO9pe9MR" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69FNg9VB1635468 for ; Fri, 16 Oct 2026 01:43:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d2AdVVW/1VpGBm6jZek+loZ/L/qPi3e0KDm+GCFxSGY=; b=QL6IvYB9Pb1vVLzF IXjkvxRV9jcqbQQ/dczG8OCsZqgZTtLmqPFKo7MEEsmtIYUS5mxCwuAZM6UbOUD6 JlPCHhp0piwaz07IGMiohubcoMP8VkWm1sDmT+lEchO1PzoR0L+J2lzKgKYa1wtw zFUbRUPuJfoKFVtbd7brLJnWKDx6RiGrwl597g11T+YwCUqHu9DKuCKVo33bg1wb Nx5ymk383xgIYrsCTX84a+IledBVnWqd+GApJ6MtDVcTurcd+lK7Mxe9EEIqWWVI y6WezmyliYkzcpF0fyum8d70JNnAoE1LcevN5/LUNqLQr8w02x/yChdaIRp6BZK2 NsJCRQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hb8r10a8f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 16 Oct 2026 01:43:53 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-89f2846ab57so656720b3a.1 for ; Thu, 15 Oct 2026 18:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792115033; x=1792719833; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=d2AdVVW/1VpGBm6jZek+loZ/L/qPi3e0KDm+GCFxSGY=; b=bO9pe9MRUhbqpltc0Th8nBQBavQam+KsdfIpBY8Tb+jiJCvYodDFLUgoqfAmW4WZNW JO+7Q0jMRpIZKcsUzQuwwS4uofsSZYkdv3PXbT1eWURdmK6Ed4SvuykDcBjvu0EjXIbK 7tG+gb4J9KnEpcsRv3gw67WNOUwqd1bVURkFECH5kqEB05hjrCCSlXCKmJYC46Kigg/n 3vTs/vaMcm6ZBpIHTQBtt9AA8qLVUij244ED2caMdT27XXOUr+KAW8oAGoM4BKt4gR3O 9Taefjd04kxAgZlqFuVy+karRHLn8fFFzCp/XVIvAAgD7duN2QTINVq7/yNzRskpdQF6 3IYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792115033; x=1792719833; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d2AdVVW/1VpGBm6jZek+loZ/L/qPi3e0KDm+GCFxSGY=; b=GxeH+knzYxJZg2/XF4xo3Poqh+9LRNMv84pvYPPJw4ySf3XZyeXqye5s4UdIThyjRL rEmhFhgT3A8yMdMWYJKnn7vtG5BllTSXleRaRCciM8uB3aRr0f2zTMTAyY4hb7jHkqUK w0EHC2gWVdg9HHLf6AfJJ8vvUs0e972KItAQb7V2uXPfouK6ncHEUwMKjZjkAkpC/owU TSB1HK/txJI1PSIsSLowPIgrUjW9i/zPhg2msRmAK1+w7OVl1JbxeqxtCqPV32CgNIIn BywkLTUXEibn5WuNWYbkxHzRG5qJ2Xr2T/cQGcMC7myQVPq7bac3SYhux3Hb5bTv55tz 7r7g== X-Forwarded-Encrypted: i=1; AKwUvBzACRvcgVPaYDTjUD/ALXi4g+FQNA4D4tvMnTDcX9DpHXujqRz590ifljog0U3Oq3t07bS+tfyd+vjh0Hw=@vger.kernel.org X-Gm-Message-State: AFq9FYJ5nadmI5OD+/719ULsgjTnlZAXuBEUpeDDrFaDsCdEK3PwiG32 GN9iHUJcqZ+TTjQNTKaPq4TSbWuBTem/Afxut23cMY7imXegJ5Kd1n6F9NlnVmGtiBmB8vNfAyP l0qJ7e8WaLytYgLYAYarmpuLfjiOh7PPqblRZ0rqwbiD1zw6V30FlEd7pZh7d5pFch6JUKbsbhd M= X-Gm-Gg: AYBFou0ElLCIPNBIokkJJJZVaJbrRaJJbxSICLzUoY+aycqXVQfbgLy07hJ8iVHCNK0 PKY0u1gkkdLmLRckJoWipB4OZo07oel8jrnmfWzp0M/btZAiBQqNueEcCE+fQzMJVxsv+zsgEav f42Q78FoYJbzpV3T8HWyidjvt+N1cgO7FtemJtwvAst5Q1U141YIv4mFRsFrOeL6bcEgkg2XpD4 mLZPWte1omgRu4mT2dOnoVQX0JJbCS9qI7qVlq6Sl2l64Q65Omavn6AiIzxYQW3zJtkGFSaSVLe Lsv4b5FH6T858bocmbyWuTzdB0fYEBr5/otrMQ0skD62Gu5r0l09abOi9/vxy1pW3GUm7UawmvN Fej8AbhxO/M881ruREJ+vSE1CHT37riLEDXIjTA+g3PctFUBfTwthE9lzKiuv+u2j/9afrsM= X-Received: by 2002:a05:6a00:2c85:b0:887:17f3:94f7 with SMTP id d2e1a72fcca58-897c3ef90dcmr17799427b3a.1.1792115032724; Thu, 15 Oct 2026 18:43:52 -0700 (PDT) X-Received: by 2002:a05:6a00:2c85:b0:887:17f3:94f7 with SMTP id d2e1a72fcca58-897c3ef90dcmr17799413b3a.1.1792115032341; Thu, 15 Oct 2026 18:43:52 -0700 (PDT) Received: from [10.133.33.32] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-89f579456a1sm326500b3a.35.2026.10.15.18.43.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 18:43:52 -0700 (PDT) Message-ID: <55cd74fd-cab2-497d-83c2-82e485b1dae5@oss.qualcomm.com> Date: Fri, 16 Oct 2026 09:43:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-current] wifi: ath12k: Fix failure to create ath12k_dp_peer on MLO reconnect To: Miaoqing Pan , jjohnson@kernel.org Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260915080053.918500-1-miaoqing.pan@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260915080053.918500-1-miaoqing.pan@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: yy8PgaMEmorURz8IirqBsUhxdmEr7dN5 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDAwNiBTYWx0ZWRfX6/AsnSqU1DUc NRsUn8GPntvcl9PsBqvaW4qXSPiYLIDnTukU2DS76t+493XnqwMgXw6CXeAmNSiT/0qy4Rg8l7L CY4sT7KIxXqW3QyK9yyC4O8dOQ4iHIQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDAwNiBTYWx0ZWRfX00p/Tn4Gdv+m RyGyza6zIbGET7pxBYeZLXx7/4S3xRESA80/IlB3D3jPlOEdmYPBVjMIfz/tFvxq/98/0K5ljKw dDC1Y3XzrdLBlg4Y+867+6EnKF73G2wFaylU3H5VeED025Rh77ou/muWYPTb9sgrG44R+GbcTRf 5prHXEH6zsa7dO4eE/DUd5PMCCrvQY03sDk9272iZIwqQFF5RIEmH6/bAW6v9KRHoycOzifBvlv sdNOcUizQglg97E2/Map6Y3NFI8yhboTT3RDtnGD4jkmevBNSb8zp1YE+JBe1VBTd627DAtd7bd cQ66hq9yAruN9akRyFNLwAAWhS7R/sK2hyvPOz3ffxl1YbvGAQRAVkWPGhacmJWMnUxKJBI5M6c bfkSQGuijKsMClzRWzxCuVGr0OLzvtIhLOeQXLryvzEOEGZBHDEMMBDbj4OLxkyCxlseEuGcsGm 1MATmZ/kDenxmuz5jYw== X-Proofpoint-GUID: yy8PgaMEmorURz8IirqBsUhxdmEr7dN5 X-Authority-Analysis: v=2.4 cv=L/CI0OT8 c=1 sm=1 tr=0 ts=6ad18159 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=FeBjiSnNOcrKIJN5QMIA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-14_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610160006 On 9/15/2026 4:00 PM, Miaoqing Pan wrote: > In ath12k_mac_op_sta_state(), when transitioning an MLO station from > IEEE80211_STA_NOTEXIST to IEEE80211_STA_NONE, after ath12k_dp_peer_create() > succeeds, on is_sta_assoc_link verification failure, it takes the > 'goto exit' path instead of 'goto peer_delete', leaving a stale dp_peer on > the dp_peers_list. > > On the next connection attempt, ath12k_dp_peer_create() finds the stale > entry and returns -EEXIST (-17): > > wlP4p1s0: failed to insert STA entry for the AP (error -17) > > Fix it by changing 'goto exit' to 'goto free_unassign_link'. > > Also, there is another error path in ath12k_mac_op_sta_state() that > jumps to peer_delete after ath12k_mac_assign_link_sta() succeeds, without > undoing the assignment through ath12k_mac_free_unassign_link_sta(). > As a result, the link RCU pointer remains assigned and a stale bit is > left in ahsta->links_map, which can trigger the same -EEXIST failure > on subsequent reconnect attempts. Fix this by redirecting that error > path to free_unassign_link instead. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3 > > Fixes: 0cd46d1f36ce ("wifi: ath12k: identify assoc link vif in station mode") > Fixes: ee16dcf573d5 ("wifi: ath12k: Define ath12k_dp_peer structure & APIs for create & delete") > Signed-off-by: Miaoqing Pan Reviewed-by: Baochen Qiang