mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Lin Ma" <linma@zju.edu.cn>
To: "Simon Horman" <horms@kernel.org>
Cc: roopa@nvidia.com, razor@blackwall.org, davem@davemloft.net,
	 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	 horatiu.vultur@microchip.com, henrik.bjoernlund@microchip.com,
	 bridge@lists.linux.dev, netdev@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] bridge: cfm: fix enum typo in br_cc_ccm_tx_parse
Date: Thu, 21 Dec 2023 00:29:16 +0800 (GMT+08:00)	[thread overview]
Message-ID: <55cdc6e4.49734.18c880f5a2f.Coremail.linma@zju.edu.cn> (raw)
In-Reply-To: <20231220161742.GM882741@kernel.org>

Hello Simon,

> 
> Thanks Lin Ma,
> 
> I agree with your analysis, that the problem was introduced in the
> cited commit, and that it is resolved by your patch.
> 

Thanks for the encouragement.

> However, as there is no user-visible bug I don't believe this reaches
> the bar for a 'fix' for Networking code. Accordingly, I think that
> the Fixes tag should be dropped. And, instead cited commit can be mentioned
> using something like "This problem was introduced by commit ...".
> 
> Also, as I don't think it is a fix I think it should be targeted at the
> net-next tree:
> 
> 	Subject: [PATCH net-next vX] ...
> 

Copy that. Yeah, once the enum IFLA_BRIDGE_CFM_CC_RDI_INSTANCE and the
IFLA_BRIDGE_CFM_CC_CCM_TX_INSTANCE keeps the value 1, everything should work
as usual. I will resend the patch as told.

> The above nits notwithstanding,
> 
> Reviewed-by: Simon Horman <horms@kernel.org>
> 

Regards
Lin

  reply	other threads:[~2023-12-20 16:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20  7:59 Lin Ma
2023-12-20 16:17 ` Simon Horman
2023-12-20 16:29   ` Lin Ma [this message]
2023-12-20 16:53     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55cdc6e4.49734.18c880f5a2f.Coremail.linma@zju.edu.cn \
    --to=linma@zju.edu.cn \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=henrik.bjoernlund@microchip.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®